Skip to content

Revert PR #22490 (Split PR devcontainer CI into pip and conda jobs) - #22497

Merged
rapids-bot[bot] merged 2 commits into
NVIDIA:mainfrom
bdice:devcontainers-are-green-and-we-rejoice-once-again
May 13, 2026
Merged

Revert PR #22490 (Split PR devcontainer CI into pip and conda jobs)#22497
rapids-bot[bot] merged 2 commits into
NVIDIA:mainfrom
bdice:devcontainers-are-green-and-we-rejoice-once-again

Conversation

@bdice

@bdice bdice commented May 13, 2026

Copy link
Copy Markdown
Contributor

Description

Reverts #22490 now that upstream issues breaking pip devcontainers are fixed in cuCascade and rapidsmpf.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@bdice
bdice requested a review from a team as a code owner May 13, 2026 21:45
@bdice
bdice requested a review from jameslamb May 13, 2026 21:45
@coderabbitai

coderabbitai Bot commented May 13, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 340954ac-aca8-480f-998f-1433a099d119

📥 Commits

Reviewing files that changed from the base of the PR and between 40de8bd and 200c077.

📒 Files selected for processing (1)
  • .github/workflows/pr.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/pr.yaml

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Consolidated CI workflow jobs, removing duplicate environment variants and simplifying the development-container build steps into a single streamlined job.
    • Cleaned up CI checks to exclude obsolete jobs and simplified the build command configuration.

Note: No user-facing changes; updates are limited to internal development infrastructure.

Walkthrough

GitHub workflow consolidation replaces separate devcontainers-conda and devcontainers-pip jobs with a single unified devcontainer job. Job dependencies in pr-builder, checks configuration, and build command structure are updated to reflect the consolidated workflow.

Changes

Devcontainer Job Consolidation

Layer / File(s) Summary
Consolidated devcontainer job definition
.github/workflows/pr.yaml
Job id devcontainer replaces devcontainers-conda and devcontainers-pip, with job permissions, removal of the hardcoded python_package_manager value, and an inline multi-line build_command script combining sccache setup, clone-rapidsmpf, environment configuration, and build-all steps.
Workflow dependency and checks updates
.github/workflows/pr.yaml
pr-builder.needs now depends on devcontainer instead of devcontainers-conda, and checks.with.ignored_pr_jobs drops devcontainers-pip.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested labels

non-breaking

Suggested reviewers

  • gforsyth
  • KyleFromNVIDIA
  • vyasr
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes a revert of PR #22490 and directly relates to the changeset, which consolidates split devcontainer jobs back into a single job.
Description check ✅ Passed The description explains the rationale for the revert (upstream issues fixed in cuCascade and rapidsmpf) and is directly related to the changeset modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@KyleFromNVIDIA KyleFromNVIDIA added bug Something isn't working non-breaking Non-breaking change labels May 13, 2026
@KyleFromNVIDIA

Copy link
Copy Markdown
Member

/merge

@rapids-bot
rapids-bot Bot merged commit d35e244 into NVIDIA:main May 13, 2026
115 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants