Fix optional operator* called on a disengaged value in clamp.cu#18655
Merged
rapids-bot[bot] merged 2 commits intorapidsai:branch-25.06from May 6, 2025
Merged
Fix optional operator* called on a disengaged value in clamp.cu#18655rapids-bot[bot] merged 2 commits intorapidsai:branch-25.06from
rapids-bot[bot] merged 2 commits intorapidsai:branch-25.06from
Conversation
davidwendt
added
bug
bdice
approved these changes
May 5, 2025
mhaseeb123
approved these changes
May 5, 2025
Contributor
Author
|
/merge |
rapids-bot
bot
merged commit afe19de
into
rapidsai:branch-25.06
109 of 110 checks passed
vyasr
added a commit
to vyasr/cudf
that referenced
this pull request
May 6, 2025
…cu (rapidsai#18655)" This reverts commit afe19de.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes invalid dereference of a
cuda::std::optionalwith no value. The new CCCL version has assert checks for this which show up in a Debug build.Error appears like this when running
gtests/CLAMP_TEST --gtest_filter=ClampTestNumeric/0.InputNull:Checklist