Use cudf::lists::distinct in Java binding#11233
Merged
rapids-bot[bot] merged 42 commits intorapidsai:branch-22.08from Jul 19, 2022
Merged
Use cudf::lists::distinct in Java binding#11233rapids-bot[bot] merged 42 commits intorapidsai:branch-22.08from
cudf::lists::distinct in Java binding#11233rapids-bot[bot] merged 42 commits intorapidsai:branch-22.08from
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
github-actions
bot
removed
CMake
mythrocks
reviewed
Jul 18, 2022
mythrocks
reviewed
Jul 18, 2022
mythrocks
reviewed
Jul 18, 2022
mythrocks
requested changes
Jul 18, 2022
Contributor
mythrocks
left a comment
mythrocks
left a comment
There was a problem hiding this comment.
Good work!
One minor documentation rephrasing requested. Plus, we've relaxed the requirement for non-sliced input columns; we should add a test to confirm.
Contributor
Author
|
@gpucibot merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Jul 22, 2022
This PR completely removes `cudf::lists::drop_list_duplicates`. It is replaced by the new API `cudf::list::distinct` which has a simpler implementation but better performance. The replacements for internal cudf usage have all been merged before thus there is no side effect or breaking for the existing APIs in this work. Closes #11114, #11093, #11053, #11034, and closes #9257. Depends on: * #11228 * #11149 * #11234 * #11233 Authors: - Nghia Truong (https://github.com/ttnghia) Approvers: - Jordan Jacobelli (https://github.com/Ethyling) - Robert Maynard (https://github.com/robertmaynard) - Vukasin Milovanovic (https://github.com/vuule) - Bradley Dice (https://github.com/bdice) URL: #11236
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Java binding has
dropListDuplicatesanddropListDuplicatesWithKeysValuesAPIs to create lists column having distinct list elements. Previously they have been implemented by calling tocudf::lists::drop_list_duplicates, which relies on stably sorting the input lists column to extract unique list elements.This PR makes the following changes:
dropListDuplicatesto usecudf::lists::distinct, which hasO(n)time complexity, andcudf::jni::lists_distinct_by_keysodropListDuplicatesWithKeysValueswill call it instead ofcudf::lists::drop_list_duplicates. This function with keys-values pair input is only needed by Spark'screate_mapfunction so its implementation will be kept inside the JNI layer instead of in libcudf.