Refactor collect_set to use cudf::distinct and cudf::lists::distinct#11228
Merged
rapids-bot[bot] merged 53 commits intorapidsai:branch-22.08from Jul 15, 2022
Merged
Refactor collect_set to use cudf::distinct and cudf::lists::distinct#11228rapids-bot[bot] merged 53 commits intorapidsai:branch-22.08from
collect_set to use cudf::distinct and cudf::lists::distinct#11228rapids-bot[bot] merged 53 commits intorapidsai:branch-22.08from
Conversation
ttnghia
added
3 - Ready for Review
jlowe
reviewed
Jul 12, 2022
mythrocks
requested changes
Jul 12, 2022
Contributor
mythrocks
left a comment
mythrocks
left a comment
There was a problem hiding this comment.
Some minor nitpicks. Looks good, otherwise.
davidwendt
reviewed
Jul 13, 2022
davidwendt
reviewed
Jul 13, 2022
davidwendt
approved these changes
Jul 14, 2022
Contributor
Contributor
Author
|
@gpucibot merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Jul 22, 2022
This PR completely removes `cudf::lists::drop_list_duplicates`. It is replaced by the new API `cudf::list::distinct` which has a simpler implementation but better performance. The replacements for internal cudf usage have all been merged before thus there is no side effect or breaking for the existing APIs in this work. Closes #11114, #11093, #11053, #11034, and closes #9257. Depends on: * #11228 * #11149 * #11234 * #11233 Authors: - Nghia Truong (https://github.com/ttnghia) Approvers: - Jordan Jacobelli (https://github.com/Ethyling) - Robert Maynard (https://github.com/robertmaynard) - Vukasin Milovanovic (https://github.com/vuule) - Bradley Dice (https://github.com/bdice) URL: #11236
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current groupby/reducttion
collect_setaggregations uselists::drop_list_duplicatesto generate set(s) of distinct elements. This PR changes that to usecudf::distinctandcudf::lists::distinctinstead, which have some advantages including:O(n)instead ofO(nlogn)) by internally using hash table instead of segmented sort.This also enables nested types support for
collect_setin spark-rapids (issue NVIDIA/spark-rapids#5508).The changes in Java code here are only to fix unit tests. Previously, they were implemented with the assumption that the
collect_setresults are sorted, now they fail when the results are no longer sorted.