Skip to content

Fix debug compile error in device_span to column_view conversion #10331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rapids-bot merged 1 commit into from
Feb 19, 2022
Merged

Fix debug compile error in device_span to column_view conversion #10331

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions cpp/include/cudf/column/column_view.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,8 +393,9 @@ class column_view : public detail::column_view_base {
: column_view(
cudf::data_type{cudf::type_to_id<T>()}, data.size(), data.data(), nullptr, 0, 0, {})
{
CUDF_EXPECTS(data.size() < std::numeric_limits<cudf::size_type>::max(),
"Data exceeds the maximum size of a column view.");
CUDF_EXPECTS(
data.size() < static_cast<std::size_t>(std::numeric_limits<cudf::size_type>::max()),
"Data exceeds the maximum size of a column view.");
}

/**
Expand Down