Fix debug compile error in device_span to column_view conversion#10331
Merged
rapids-bot[bot] merged 1 commit intorapidsai:branch-22.04from Feb 19, 2022
Merged
Conversation
vuule
approved these changes
Feb 18, 2022
ttnghia
approved these changes
Feb 18, 2022
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #10331 +/- ##
================================================
+ Coverage 10.42% 10.63% +0.21%
================================================
Files 119 122 +3
Lines 20603 20940 +337
================================================
+ Hits 2148 2228 +80
- Misses 18455 18712 +257
Continue to review full report at Codecov.
|
Contributor
|
@gpucibot merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a compile error in
column_view(device_span)constructor when building libcudf in Debug.The above also includes the command line compile that creates the error.
The solution implemented in this PR casts the
size_typemax()value tostd::size_tbefore comparing it to the span'ssize()value.The change implemented in #10302 introduced this conversion.