Update initial cpp unittests #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gigony
added
improvement
quasiben
approved these changes
Oct 13, 2021
Member
|
@gpucibot merge |
jakirkham
reviewed
Oct 29, 2021
benchmarks/config.h
Outdated
| std::string benchmark_counters_tabular; | ||
| std::string v; // <verbosity> | ||
|
|
||
| std::string get_input_path(const char* default_value = "generated/tiff_stripe_4096x4096_256.tif") const |
Member
There was a problem hiding this comment.
Should default_value be std::string? Similar lines below
Contributor
Author
There was a problem hiding this comment.
Thanks! Updated to const std::string
Comment on lines
-24
to
+25
| std::string input_file = "test_data/private/generic_tiff_000.tif"; | ||
| std::string test_folder; | ||
| std::string test_file; |
Member
There was a problem hiding this comment.
We may want to revisit at some point and look at using std::filesystem::path. Though that requires C++17 and we were already using std::string. So just a future note
Contributor
Author
There was a problem hiding this comment.
Thanks!
Created a issue for following up:
gigony
force-pushed
the
update_cpp_tests
branch
from
b629a0a to
229abaf
Compare
gigony
force-pushed
the
update_cpp_tests
branch
from
229abaf to
8a7dd7d
Compare
This was referenced Oct 30, 2021
jakirkham
approved these changes
Nov 3, 2021
Member
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update existing unit test code to use generated test image and allow external image specified by the parameter.
Updating
runscript to pre-generate the necessary test images and running C++ unit tests would be set up in a separate PR.