Refactor netpol creation and add two new netpols for metrics-server and snapshot-validation-webhook#5521
Merged
brandond merged 1 commit intorancher:masterfrom Feb 26, 2024
Merged
Conversation
Eliminate copy-pasted netpol creation functions in favor of iterating over templates; Add new netpols for snapshot validation webhook and metrics-server Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
7151a61 to
24137d4
Compare
briandowns
approved these changes
Feb 26, 2024
fmoral2
approved these changes
Feb 26, 2024
ShylajaDevadiga
approved these changes
Feb 26, 2024
galal-hussein
approved these changes
Feb 26, 2024
This was referenced Feb 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Refactor netpol creation and add two new netpols
Continues fixing issues revealed by the removal of the allow-all policy in #5318
Types of Changes
bugfix
Verification
See linked issues
Testing
Linked Issues
User-Facing Change
Further Comments