Only run flannel host-network CIS netpol controller when using canal CNI#5318
Merged
brandond merged 1 commit intorancher:masterfrom Feb 8, 2024
Merged
Conversation
This will leave the existing policy in place in case anyone was depending on it, but new clusters will not have it. Administrators can delete if if they wish, without risk of the controller putting it back. Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
force-pushed
the
fix-flannel-host-networking-netpol
branch
from
5320c49 to
a3216ec
Compare
thomasferrandiz
approved these changes
Jan 25, 2024
manuelbuil
approved these changes
Jan 25, 2024
This was referenced Feb 12, 2024
This was referenced Feb 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Only run flannel host-network CIS netpol controller when using canal CNI
This will leave the existing policy in place in case anyone was depending on it, but new clusters will not have it. Administrators can delete if if they wish, without risk of the controller putting it back.
After some internal discussion, it appears that this was added when canal was our only CNI, and the policy this controller maintains should not be present when flannel is not in use. We are not going to actively remove it in case users are depending on it, but new clusters will not have it.
Types of Changes
bugfix
Verification
Check for existence of policy on a new cluster
Testing
Linked Issues
User-Facing Change
Further Comments