Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneeded 07_cloud-metadata.yaml config file #343

Merged
merged 1 commit into from
Jun 29, 2021
Merged

Remove unneeded 07_cloud-metadata.yaml config file #343

merged 1 commit into from
Jun 29, 2021

Conversation

davidcassany
Copy link
Contributor

Supersedes #331

@davidcassany
Copy link
Contributor Author

https://github.com/rancher-sandbox/cOS-toolkit/blob/39a14199deb8463177d0ab3f7946e4f775c85074/packages/cloud-config/oem/00_rootfs.yaml#L17-L20

already includes the cdrom

@davidcassany davidcassany mentioned this pull request Jun 29, 2021
Closed
@mudler
Copy link
Contributor

mudler commented Jun 29, 2021

One side of tests is green (nonsquashfs), I'd say to merge it as there could be no difference with squashfs ones, no sense to waste CI time 👍

@mudler mudler merged commit 75a9f45 into master Jun 29, 2021
@mudler mudler deleted the clear_data_source_cloud_config_file branch June 29, 2021 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mudler mudler mudler approved these changes

@Itxaka Itxaka Itxaka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidcassany @mudler @Itxaka