Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always enable cdrom datasource #331

Closed
wants to merge 1 commit into from
Closed

Always enable cdrom datasource #331

wants to merge 1 commit into from

Conversation

ibuildthecloud
Copy link
Contributor

@ibuildthecloud ibuildthecloud commented Jun 25, 2021 •
edited
Loading

I'm in the middle of refactoring quite a bit of things so haven't fully tested this change. One thing that confused me is that the path is set to /system/oem. Isn't that path read-only? I'm confused on how this works.

@ibuildthecloud
Always enable cdrom datasource
cf770f2 
Signed-off-by: Darren Shepherd <[email protected]>
@mudler mudler requested a review from davidcassany June 28, 2021 12:45
@davidcassany
Copy link
Contributor

I'm in the middle of refactoring quite a bit of things so haven't fully tested this change. One thing that confused me is that the path is set to /system/oem. Isn't that path read-only? I'm confused on how this works.

Indeed this /system/oem setup does not work as it is read-only. I can't remember how it happened that I did it this way, my bad... I guess these are leftovers from my tests over squashfs where the whole root is overlayed as a live image.

I'd simply remove this file and keep the current 00_rootfs.yaml that allows to pull user-data from the cloud before setting almost anything, so it give you freedom to configure /run/cos/cos-layout.env as part of the data source from cloud providers.

@davidcassany davidcassany mentioned this pull request Jun 29, 2021
Merged
@davidcassany
Copy link
Contributor

Closing this PR in favor of #343, feel free to reopen if any doubt or concern.

frelon pushed a commit to frelon/elemental-toolkit that referenced this pull request May 12, 2023
@davidcassany
Remove sanity check for SUSE based systems on efi installation (ranch…
3ddb911 
…er#331)

Shim images are under /usr/share/efi/aarch64/shim.efi in arm64
hence the architecture string is not included within the path.
Same happens with the grub.efi image.

Signed-off-by: David Cassany <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidcassany davidcassany Awaiting requested review from davidcassany

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ibuildthecloud @davidcassany