Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: incorrectly defaulting advertise address #153

Merged
merged 1 commit into from
Jun 30, 2023
Merged

fix: incorrectly defaulting advertise address #153

merged 1 commit into from
Jun 30, 2023

Commits on Jun 30, 2023

  1. fix: incorrectly defaulting advertise address 

    With the recent change to introduce new registration methods we started
to default the `advertiseAddress` to the "registration address" if the
registration method of `address` was used. This caused the kube-api
server to be startedw tith that address. If you then used a VIP/LB
solution like kube-vip or metalb that runs within cluster it caused
pods to not start start as there is a chicken and egg scenario.

This change removes that defaulting and also adds a sample that uses
kube-vip.

Signed-off-by: Richard Case <[email protected]>
    @richardcase
    richardcase committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    6e2efbe View commit details
    Browse the repository at this point in the history