fix: incorrectly defaulting advertise address #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Relates to this: https://gitlab.com/sylva-projects/sylva-core/-/issues/378 |
|
This looks very good! We'll test this out as soon as this ships. |
With the recent change to introduce new registration methods we started to default the `advertiseAddress` to the "registration address" if the registration method of `address` was used. This caused the kube-api server to be startedw tith that address. If you then used a VIP/LB solution like kube-vip or metalb that runs within cluster it caused pods to not start start as there is a chicken and egg scenario. This change removes that defaulting and also adds a sample that uses kube-vip. Signed-off-by: Richard Case <[email protected]>
|
NOTE: merged directly instead of waiting for reviews so that a release could be done asap. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
With the recent change to introduce new registration methods we started to default the
advertiseAddressto the "registration address" if the registration method ofaddresswas used. This caused the kube-api server to be startedw tith that address. If you then used a VIP/LB solution like kube-vip or metalb that runs within cluster it caused pods to not start start as there is a chicken and egg scenario.This change removes that defaulting and also adds a sample that uses kube-vip.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist: