Fix list and button tabindex that harm accessibility and keyboard control #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
LadySolveig
commented
May 13, 2025
LadySolveig
commented
- Remove the wrong tabindex (-1) attribute from buttons completely as it harms accessibility and prevent keyboard access to the functionality of the button.
- Remove unnecessary automatic assignment of the tabIndex attribute on toogleMenu
- Leave tabindex -1 for p tags to avoid impairing the functionality of the buttons (reset and close)
Remove the wrong tabindex (-1) attribute from buttons completely as it harms accessibility and prevent keyboard access to the functionality of the button.
…toggleMenu - Leave tabindex -1 for p tags to avoid impairing the functionality of the buttons (reset and close)
This was referenced May 13, 2025
ranbuch
approved these changes
May 28, 2025
Contributor
Author
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.