[5.2] wip Update accessibility toolbar

[brianteeman]

Updated to v6
adds some new functions

• update to latest library
• increase/decrease line height (disable until/if fixed upstream)
• disable animations (NEW)
• default emoji icon no longer skewed
• link to optional accessibility statement (NEW)
• dark mode
• Angie icon set (https://github.com/angieradtke/Accessibility-plugin-icons)
• Auto(partial)hide icon and expand on focus
• extract css to external file to allow greater customisation
• add position option
• add custom function to use open dyslexie font leave for another day
• translate "hotkey"

Still to do

• Fix hot keys not working Some hotkeys still dont work ranbuch/accessibility#68
• Save/close Refresh icons replacing the icons ranbuch/accessibility#67
• web assets ?
• Default icon replacing the icons ranbuch/accessibility#67
• Missing some icons

Working with upstream to resolve multiple bugs

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

[Quy]

Can you please add #39102 to the to-do list?

[HLeithner]

This pull request has been automatically rebased to 5.2-dev.

[brianteeman]

Allowing User to insert JS in backed, is kind of the same as allowing User insert PHP in backend.

Doh - silly me

[brianteeman]

Since I started this PR upstream has completely changed (again)

It is now possible to create our own ui for the toolbar instead of the hacky solutions that were previously available

See the Custom Styling section https://ranbuch.github.io/accessibility/site/

[brianteeman]

Note: The icons from Angie will need to be adjusted if we want to use them as an icon font (doesnt support multiple colors/shades) although I guess if the latest upstream changes are used to create our own UI for the toolbar then svg could be used

[drmenzelit]

Doing some tests today. The hotkeys work for me, but ctrl+alt+q (animations) in Chrome but not in Firefox
ctrl+alt+r activate the reading guide an opens something from my graphic card too, but that is something specific from my PC

[brianteeman]

yeah the hotkeys are weird. No idea what to do there

[drmenzelit]

IBM Equal Access Accessibility Checker and in the Firefox Accessibility tab I get some errors / things to review... can we do something here?

[brianteeman]

As you said you didnt want to create our own ui these are both upstream issues to resolve.

[brianteeman]

i think it is probably better to use the fontawesome web asset than the icons generated by angie

[chmst]

My vision is fontawesome icons as default but an option for custom icons.

[brianteeman]

dont be confused with the icons for the toolbar actions and the icon for the button

[LadySolveig]

Just for reference, I have submitted a PR upstream for the tabindex issue ranbuch/accessibility#87 PR ranbuch/accessibility#86

[brianteeman]

I gave up looking at this due to the complete lack of any communication from the accessibility team

[LadySolveig]

@brianteeman would you mind reopening this PR? So that hopefully we can bring the new version into 5.4

[brianteeman]

It cant be re-opened as the 5.2-dev branch has been deleted here so github wont let me.

While I was working on it I discovered loads of bugs which he fixed but it really requires a rewrite of the plugin to be able to use the icons the way we want to. The implementation that ranbuch did for non-material icons is a pia

[LadySolveig]

Do you want to open a new one or should I do it? Would really like to work with you on this.

[brianteeman]

I gave up looking at this due to the complete lack of any communication from the accessibility team

Do as you wish. I won't waste any more if my time on it as the accessibility team clearly are not interested

[LadySolveig]

Thank you, then I am pleased to build on the work you have already done.