Fix Homebrew deployment on CircleCI

[ulope]

No description provided.

[rakanalh]

Looks good... so you're pretty much:

1. Adding github.com to known_hosts because of not in known_hosts (IIRC) error
2. Adding support to add RCs to homebrew

Edit: Weird error in circle CI lint step... wondering how that happend 🤔

[rakanalh]

Was removing the space in -i.bak done on purpose?

[ulope]

Yes it was. Previously (on Travis) this ran on macOS which has BSD sed. On Circle this is now running in a linux container with gnu sed which (for whatever reason) doesn't accept a space after the -i option.

[ulope]

1. Adding github.com to known_hosts because of not in known_hosts (IIRC) error

Yes, with additional checking of the key fingerprint to prevent MitM attacks.

2. Adding support to add RCs to homebrew

Also yes. Previously the -rcX suffixes would 'pile up' after multiple rc releases (e.g. raiden-v0.100.2-rc2-rc3-macOS.zip) since the regex didn't capture them.

Edit: Weird error in circle CI lint step... wondering how that happend 🤔

👀

That line hasn't been touched since early 2018...

[ulope]

Ok found the reason for the lint failure. On Circle we get astroid==2.2.0 (as a dependency of pylint) which seems to cause this error.

Related: pylint-dev/astroid#651, pylint-dev/pylint#2774

/edit: @konradkonrad already fixed it another way in #3557. Still we should pin astroid since it seems to break other stuff as well.

[codecov]

Codecov Report

Merging #3564 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3564      +/-   ##
==========================================
- Coverage   77.15%   77.12%   -0.03%     
==========================================
  Files         103      103              
  Lines       13631    13631              
  Branches     1913     1913              
==========================================
- Hits        10517    10513       -4     
- Misses       2449     2450       +1     
- Partials      665      668       +3

Impacted Files	Coverage Δ
raiden/accounts.py	47.56% <100%> (ø)	⬆️
raiden/network/proxies/secret_registry.py	82.71% <0%> (-1.24%)	⬇️
raiden/tasks.py	73.8% <0%> (-0.8%)	⬇️
raiden/network/transport/matrix/client.py	69.2% <0%> (-0.77%)	⬇️
raiden/network/transport/matrix/transport.py	75.41% <0%> (-0.76%)	⬇️
raiden/transfer/events.py	77.55% <0%> (+0.39%)	⬆️
raiden/raiden_service.py	89.7% <0%> (+0.54%)	⬆️
raiden/transfer/mediated_transfer/events.py	84.11% <0%> (+0.93%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6e95b9...4ab8b9d. Read the comment docs.