Skip to content

Comments

Fix no-member complaint by pylint#3557

Merged
konradkonrad merged 1 commit intoraiden-network:masterfrom
konradkonrad:fix_astroid_complaint
Feb 27, 2019
Merged

Fix no-member complaint by pylint#3557
konradkonrad merged 1 commit intoraiden-network:masterfrom
konradkonrad:fix_astroid_complaint

Conversation

@konradkonrad
Copy link
Contributor

Newest astroid version 2.2.0 started to complain about no-member for
Exception.errno for (JSONDecodeError, KeyError, UnicodeDecodeError),
albeit there was an isinstance check before accessing it. By
separating the except blocks, I was able to mute that problem.

Newest `astroid` version 2.2.0 started to complain about `no-member` for
`Exception.errno` for `(JSONDecodeError, KeyError, UnicodeDecodeError)`,
albeit there was an `isinstance` check before accessing it. By
separating the `except` blocks, I was able to mute that problem.
@codecov
Copy link

codecov bot commented Feb 27, 2019

Codecov Report

Merging #3557 into master will decrease coverage by 0.11%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3557      +/-   ##
==========================================
- Coverage   77.14%   77.03%   -0.12%     
==========================================
  Files         103      103              
  Lines       13601    13602       +1     
  Branches     1912     1912              
==========================================
- Hits        10493    10478      -15     
- Misses       2445     2457      +12     
- Partials      663      667       +4
Impacted Files Coverage Δ
raiden/accounts.py 47.56% <100%> (-0.3%) ⬇️
raiden/utils/__init__.py 67.44% <0%> (-4.66%) ⬇️
raiden/network/transport/udp/udp_transport.py 90.51% <0%> (-0.8%) ⬇️
raiden/transfer/events.py 76.37% <0%> (-0.79%) ⬇️
raiden/network/transport/matrix/transport.py 75.19% <0%> (-0.62%) ⬇️
raiden/transfer/mediated_transfer/mediator.py 89.12% <0%> (-0.43%) ⬇️
raiden/tasks.py 74.6% <0%> (+0.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6de4082...7049aff. Read the comment docs.

@konradkonrad konradkonrad merged commit 931a47f into raiden-network:master Feb 27, 2019
@konradkonrad konradkonrad deleted the fix_astroid_complaint branch February 27, 2019 11:02
@konradkonrad
Copy link
Contributor Author

ref: pylint-dev/pylint#2774

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants