Skip to content

[Sampling Replay 8/8] Explain sampling-support replay - #3353

Closed
nanjiangwill wants to merge 6 commits into
radixark:mainfrom
nanjiangwill:docs/sampling-support-replay
Closed

nanjiangwill wants to merge 6 commits into
radixark:mainfrom
nanjiangwill:docs/sampling-support-replay

Conversation

@nanjiangwill

@nanjiangwill nanjiangwill commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Stack position

Part 8/8 of the bounded sampling-support replay series. Merge after #3352. #3321 is merged in main.

Layer-only diff: nanjiangwill/miles@test/sampling-replay-e2e...docs/sampling-support-replay

Review umbrella: #3354.

Summary

  • Explain why bounded rollout sampling and full-vocabulary actor normalization differ.
  • Define the fixed-support replay objective and configuration.
  • Document the Miles and SGLang ownership boundary.
  • Document current temperature, router, prefill, penalty, KL, and distillation constraints, including that the v0.5.20 router limitation is request-side typed serialization rather than response stripping.
  • Add the feature to Advanced navigation and both CLI sampling references.
  • Explain how to interpret rollout/trainer log-probability mismatch metrics after the first update.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@nanjiangwill
nanjiangwill force-pushed the docs/sampling-support-replay branch from e6ba953 to 9f68c61 Compare September 21, 2026 18:59
@nanjiangwill

Copy link
Copy Markdown
Contributor Author

Closing this layer-specific review PR in favor of the single integrated sampling-replay PR #3354. The implementation and validation remain available there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant