Repository navigation
[Sampling Replay 7/8] Validate sampling-support replay end to end - #3352
Closed
nanjiangwill wants to merge 5 commits into
Closed
nanjiangwill wants to merge 5 commits into
nanjiangwill wants to merge 5 commits into
Conversation
nanjiangwill
requested review from
Rockdu,
Shi-Dong,
Zhichenzzz,
fzyzcjy,
guapisolo,
jybsuper,
maocheng23,
yueming-yuan and
yushengsu-thu
as code owners
September 21, 2026 07:33
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
This was referenced Sep 21, 2026
nanjiangwill
force-pushed
the
test/sampling-replay-e2e
branch
from
September 21, 2026 18:59
c09dd72 to
eb53911
Compare
Contributor
Author
|
Closing this layer-specific review PR in favor of the single integrated sampling-replay PR #3354. The implementation and validation remain available there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack position
Part 7/8 of the bounded sampling-support replay series. Merge after #3351. #3321 is merged in
main.Layer-only diff: nanjiangwill/miles@feat/sampling-replay-validation...test/sampling-replay-e2e
Review umbrella: #3354.
Summary
Add one focused 2xH200 Qwen3-0.6B E2E that exercises:
The recipe intentionally excludes KL, entropy, and unrelated algorithm flags so failures remain attributable to sampling-support replay.