Temporarily remove vanilla fault tolerance for the eval fleet - #2497
Open
fzyzcjy wants to merge 1 commit into
Open
Temporarily remove vanilla fault tolerance for the eval fleet#2497fzyzcjy wants to merge 1 commit into
fzyzcjy wants to merge 1 commit into
Conversation
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-180
branch
2 times, most recently
from
August 13, 2026 03:11
c9fa012 to
b149ac9
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-179
branch
from
August 13, 2026 03:25
5490f30 to
5b6626c
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-180
branch
2 times, most recently
from
August 13, 2026 06:00
4246f0f to
c004a9b
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-179
branch
2 times, most recently
from
August 13, 2026 06:39
b0f4508 to
806b664
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-180
branch
3 times, most recently
from
August 14, 2026 04:49
ab03185 to
bd22007
Compare
All three calls at the top of EvalFleet.pin were broken: RolloutServer no
longer has recover() or wait_all_engines_alive(), and
ServerCell.probe_and_mark_dead() referenced is_allocated/_mark_stopped,
which no longer exist, so it raised AttributeError on every call. The
surrounding try/except swallowed the failure into EvalSkip("unhealthy"),
so every eval-fleet pin silently degraded to a skipped eval.
The eval fleet does not support fault tolerance, so the path is removed
rather than reimplemented: pin now goes straight to the weight load, and
the now-unreachable RolloutServer.probe_and_mark_dead and
ServerCell.probe_and_mark_dead are deleted along with their tests.
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-180
branch
from
August 14, 2026 05:52
bd22007 to
d663ee4
Compare
This was referenced Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1837