Remove the now-unused stopped cell state - #2069
Open
fzyzcjy wants to merge 1 commit into
Open
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-81
branch
from
August 2, 2026 09:06
0239424 to
0bd2d76
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-82
branch
2 times, most recently
from
August 2, 2026 09:44
611ed8c to
a39737b
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-81
branch
2 times, most recently
from
August 2, 2026 10:02
4d74f7f to
bf6cf74
Compare
fzyzcjy
requested review from
Shi-Dong,
Zhichenzzz,
guapisolo,
jybsuper and
yushengsu-thu
as code owners
August 2, 2026 10:02
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-82
branch
from
August 2, 2026 10:02
a39737b to
8fc2cf2
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-81
branch
from
August 2, 2026 12:41
bf6cf74 to
4bd757e
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-82
branch
2 times, most recently
from
August 3, 2026 23:44
e7ed9be to
98a97cf
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-81
branch
2 times, most recently
from
August 4, 2026 00:39
8e2cfe1 to
fa0fe27
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-82
branch
from
August 4, 2026 00:39
98a97cf to
cae3d4a
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-81
branch
from
August 4, 2026 06:55
fa0fe27 to
5c6919f
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-82
branch
from
August 4, 2026 06:55
cae3d4a to
66ccbf1
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-81
branch
from
August 4, 2026 07:28
5c6919f to
923276c
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-82
branch
from
August 4, 2026 07:28
66ccbf1 to
ef9c0b7
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-81
branch
from
August 4, 2026 07:35
923276c to
15144a1
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-82
branch
from
August 4, 2026 07:35
ef9c0b7 to
02d4114
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-81
branch
from
August 6, 2026 03:48
15144a1 to
b8cab15
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-82
branch
from
August 6, 2026 03:49
02d4114 to
cad0621
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-82
branch
from
August 9, 2026 23:33
a7ea262 to
1462cf4
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-81
branch
from
August 9, 2026 23:33
bc7ccd6 to
03ddf32
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-82
branch
from
August 10, 2026 00:44
1462cf4 to
fd181c3
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-81
branch
from
August 10, 2026 06:05
5a0390d to
9ffaee9
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-82
branch
from
August 10, 2026 06:05
fd181c3 to
9609dcc
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-81
branch
from
August 10, 2026 16:07
9ffaee9 to
b324b13
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-82
branch
from
August 10, 2026 16:07
9609dcc to
765db35
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-81
branch
from
August 10, 2026 16:34
b324b13 to
a29e6bb
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-82
branch
from
August 10, 2026 16:34
765db35 to
2c3853e
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-81
branch
from
August 12, 2026 02:48
a29e6bb to
fe4e2c1
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-82
branch
2 times, most recently
from
August 12, 2026 09:32
ea06df8 to
6f6f1dc
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-81
branch
2 times, most recently
from
August 12, 2026 14:31
52ddf93 to
bb5a4c8
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-82
branch
2 times, most recently
from
August 12, 2026 14:36
2a107f6 to
d568b31
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-81
branch
from
August 12, 2026 23:56
16d7bb4 to
9ac274a
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-82
branch
2 times, most recently
from
August 13, 2026 01:13
974c52d to
b6cd643
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-81
branch
2 times, most recently
from
August 13, 2026 03:11
9d31364 to
b54752c
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-82
branch
3 times, most recently
from
August 13, 2026 06:00
bd8a5be to
dae9e8a
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-81
branch
from
August 13, 2026 06:00
76c9c3e to
d496874
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-82
branch
from
August 13, 2026 06:39
dae9e8a to
ea9eded
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-81
branch
from
August 13, 2026 06:39
d496874 to
adde395
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-82
branch
from
August 14, 2026 04:45
ea9eded to
f34b9a1
Compare
guapisolo
approved these changes
Aug 27, 2026
guapisolo
left a comment
guapisolo
left a comment
Collaborator
There was a problem hiding this comment.
[P2] #2069 removes _mark_stopped() while the eval health path can still call it after a failed probe, causing AttributeError; #2497 removes that path before #2176, and the repair remains through #2649. [P3] It also leaves is_allocated tautological and dead lifecycle branches; #2087 begins the cleanup and #2497 completes it before #2176, with no post-checkpoint follow-up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1837