Skip to content

fix: correct generated group type annotations #2241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
guapisolo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: correct generated group type annotations #2241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion miles/rollout/inference_rollout/inference_rollout_common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ async def generate_and_rm_group(
sampling_params: dict[str, Any],
evaluation: bool = False,
sample_done_callback: Callable[[], None] | None = None,
) -> list[Sample]:
) -> list[Sample | list[Sample]]:
args = state.args

if state.aborted:
Expand Down
2 changes: 1 addition & 1 deletion miles/rollout/inference_rollout/inference_rollout_train.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ async def generate_rollout_async(
logger.debug(f"[rollout] asyncio.wait returned: {len(done)} done, {len(pendings)} pending")
for task in done:
try:
group: list[Sample] = task.result()
group: list[Sample | list[Sample]] = task.result()
except Exception as e:
logger.error(f"[rollout] Task raised exception: {e!r}", exc_info=True)
continue
Expand Down
Loading