fix: correct generated group type annotations - #2241
Open
guapisolo wants to merge 1 commit into
Open
Conversation
generate_and_rm_group gathers per-sample results that may each expand to multiple samples. Describe the produced group and its direct consumer with the actual nested union type.
guapisolo
requested review from
Shi-Dong,
fzyzcjy and
yueming-yuan
as code owners
August 7, 2026 03:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Correct generated rollout group annotations to include expanded sample lists.
Symptom & Reproduction
generate_and_rm_groupdeclares a flatlist[Sample]even though one trajectory can expand intolist[Sample], so type consumers receive a false flat-only contract.typing.get_type_hints(generate_and_rm_group)["return"]while tracing theasyncio.gatherinputs fromgenerate_and_rm.Root Cause
generate_and_rmreturnsSample | list[Sample]per trajectory.asyncio.gatherpreserves each trajectory result inside the group list.generate_and_rm_groupand its direct sync consumer declared onlylist[Sample].Fix
Declare the producer result and the direct sync consumer as
list[Sample | list[Sample]], matching the existing runtime shape without changing generation, ordering, reward, or filtering behavior.Verification
get_type_hints()assertion verifies the corrected contract.Review Focus
generate_and_rm_groupandgenerate_rollout_async.