Key the trainer cells by cell id instead of cell index - #2167
Open
fzyzcjy wants to merge 1 commit into
Open
Conversation
fzyzcjy
requested review from
Shi-Dong,
Zhichenzzz,
guapisolo,
jybsuper,
maocheng23 and
yueming-yuan
as code owners
August 4, 2026 14:16
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-140
branch
from
August 6, 2026 03:47
c198e55 to
df47ab9
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-151
branch
2 times, most recently
from
August 6, 2026 07:04
2dbeb88 to
8e28bac
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-140
branch
from
August 6, 2026 07:04
df47ab9 to
489cd63
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-151
branch
2 times, most recently
from
August 10, 2026 00:44
c58d22a to
bbc469f
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-140
branch
from
August 10, 2026 06:01
02dc5cf to
2934405
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-151
branch
from
August 10, 2026 06:02
bbc469f to
524556f
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-140
branch
from
August 10, 2026 16:06
2934405 to
a2bb4e8
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-151
branch
from
August 10, 2026 16:06
524556f to
312d2bd
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-140
branch
from
August 10, 2026 16:33
a2bb4e8 to
0cb0f4c
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-151
branch
2 times, most recently
from
August 12, 2026 02:48
c219233 to
9d48347
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-140
branch
from
August 12, 2026 09:32
3b30563 to
f811114
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-151
branch
from
August 12, 2026 09:32
9d48347 to
78a4ba9
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-140
branch
from
August 12, 2026 14:31
f811114 to
0d9b7a2
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-151
branch
2 times, most recently
from
August 12, 2026 14:36
0306486 to
ff00752
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-140
branch
from
August 12, 2026 23:56
9692b60 to
5733bff
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-151
branch
from
August 12, 2026 23:56
ff00752 to
0a5f78a
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-140
branch
from
August 13, 2026 01:13
5733bff to
8638ecf
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-151
branch
3 times, most recently
from
August 13, 2026 03:25
95d5233 to
82233d7
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-140
branch
from
August 13, 2026 06:00
0d63f3a to
56ef192
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-151
branch
4 times, most recently
from
August 14, 2026 04:50
d3b94c4 to
7dfa0e7
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-140
branch
2 times, most recently
from
August 14, 2026 05:53
6c14b33 to
7067ee0
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-151
branch
from
August 14, 2026 05:53
7dfa0e7 to
53c9ad1
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-151
branch
from
August 28, 2026 11:41
53c9ad1 to
b8ee260
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-140
branch
from
August 29, 2026 12:38
5fc1444 to
7c2bf61
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-151
branch
from
August 29, 2026 12:38
b8ee260 to
0cdb4e2
Compare
fzyzcjy
commented
Aug 30, 2026
fzyzcjy
left a comment
fzyzcjy
left a comment
Collaborator
Author
There was a problem hiding this comment.
No correctness or regression issue introduced by this op remains at the target safe deliver. The cell-ID plumbing is consistent across the trainer controller, API handler, worker manager/provider, actor actions, and dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1837