Keep one addr_info per cell and read the engine topology from RayWorkerManager - #2060
Open
fzyzcjy wants to merge 1 commit into
Open
Keep one addr_info per cell and read the engine topology from RayWorkerManager#2060fzyzcjy wants to merge 1 commit into
fzyzcjy wants to merge 1 commit into
Conversation
fzyzcjy
requested review from
Shi-Dong,
Zhichenzzz,
guapisolo,
jybsuper,
maocheng23 and
yueming-yuan
as code owners
August 2, 2026 08:56
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-74
branch
from
August 2, 2026 10:01
1c63611 to
b4d3cc7
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-71
branch
from
August 2, 2026 10:01
c646bc5 to
44edc76
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-74
branch
from
August 2, 2026 12:41
b4d3cc7 to
7e4f5b7
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-71
branch
4 times, most recently
from
August 4, 2026 06:55
c08007c to
96c2166
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-74
branch
from
August 4, 2026 06:55
446b163 to
3924c93
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-71
branch
from
August 4, 2026 07:27
96c2166 to
29a9ca8
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-74
branch
from
August 4, 2026 07:27
3924c93 to
82c31bd
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-71
branch
from
August 4, 2026 07:34
29a9ca8 to
0057289
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-74
branch
2 times, most recently
from
August 6, 2026 03:48
f8fe3bb to
e83d68a
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-71
branch
2 times, most recently
from
August 6, 2026 07:04
0ca4551 to
bec133f
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-74
branch
2 times, most recently
from
August 9, 2026 23:33
d0112bc to
c6a026a
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-71
branch
from
August 9, 2026 23:33
bec133f to
aa58d87
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-74
branch
from
August 10, 2026 00:44
c6a026a to
c16d705
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-71
branch
from
August 10, 2026 00:44
aa58d87 to
56f9144
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-71
branch
from
August 10, 2026 06:04
56f9144 to
330b868
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-74
branch
from
August 10, 2026 06:04
c16d705 to
d1f719f
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-71
branch
from
August 10, 2026 16:07
330b868 to
e2336a1
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-74
branch
2 times, most recently
from
August 10, 2026 16:34
d009193 to
d5bdd09
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-71
branch
3 times, most recently
from
August 12, 2026 09:32
ca4af71 to
ea3432d
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-74
branch
from
August 12, 2026 14:31
9967d8f to
bcefde2
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-71
branch
2 times, most recently
from
August 12, 2026 14:36
0336efa to
ed13622
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-74
branch
from
August 12, 2026 23:56
224173e to
4744b58
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-71
branch
from
August 12, 2026 23:56
ed13622 to
26a890e
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-74
branch
from
August 13, 2026 01:13
4744b58 to
3643717
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-71
branch
5 times, most recently
from
August 13, 2026 06:39
9b86ba7 to
cb3eb64
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-74
branch
from
August 14, 2026 04:45
513dd98 to
d58a444
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-71
branch
from
August 14, 2026 04:46
cb3eb64 to
b0cc6f8
Compare
guapisolo
approved these changes
Aug 27, 2026
guapisolo
left a comment
guapisolo
left a comment
Collaborator
There was a problem hiding this comment.
Codex stack review: [P1] #2060 leaves the Miles dashboard without engine topology because the reader moves before engine ownership and its lookup contract is mismatched. #2063 completes the ownership migration and #2167 aligns the lookup contract; both fixes land before safe-merge checkpoint #2176 and remain present through checked tip #2649.
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-74
branch
from
August 29, 2026 12:38
d58a444 to
7e3a61e
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-71
branch
from
August 29, 2026 12:38
b0cc6f8 to
45d726a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1837