Return one train step output type from every trainer backend and scenario - #2150
Open
fzyzcjy wants to merge 1 commit into
Open
Return one train step output type from every trainer backend and scenario#2150fzyzcjy wants to merge 1 commit into
fzyzcjy wants to merge 1 commit into
Conversation
fzyzcjy
requested review from
Rockdu,
Shi-Dong,
Zhichenzzz,
guapisolo,
maocheng23,
yueming-yuan and
yushengsu-thu
as code owners
August 4, 2026 14:15
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-147
branch
from
August 6, 2026 03:47
736ff0c to
bd7ec5e
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-148
branch
from
August 6, 2026 03:47
448aab8 to
55df6d5
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-147
branch
from
August 6, 2026 07:04
bd7ec5e to
baec89c
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-148
branch
2 times, most recently
from
August 9, 2026 23:32
73294c6 to
ef806bd
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-147
branch
from
August 10, 2026 00:44
62b815a to
753dd27
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-148
branch
from
August 10, 2026 00:44
ef806bd to
322e378
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-147
branch
from
August 10, 2026 06:01
753dd27 to
99ed3a7
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-148
branch
3 times, most recently
from
August 10, 2026 16:34
f4a77df to
a169744
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-147
branch
from
August 10, 2026 16:34
7e82262 to
67fafef
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-148
branch
from
August 12, 2026 02:48
a169744 to
8bd91d2
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-147
branch
from
August 12, 2026 02:48
67fafef to
8829029
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-148
branch
from
August 12, 2026 09:32
8bd91d2 to
c6bf462
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-147
branch
from
August 12, 2026 14:31
7abc2e2 to
dda0e09
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-148
branch
from
August 12, 2026 14:31
c6bf462 to
bf4454f
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-147
branch
from
August 12, 2026 14:36
dda0e09 to
c5c8577
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-148
branch
2 times, most recently
from
August 12, 2026 23:56
9f69242 to
d6267ea
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-147
branch
from
August 13, 2026 01:13
3a55156 to
826487b
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-148
branch
2 times, most recently
from
August 13, 2026 03:11
2284250 to
9c23207
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-147
branch
from
August 13, 2026 03:25
01fc3b1 to
e1a1423
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-148
branch
from
August 13, 2026 03:25
9c23207 to
3e2b7dd
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-147
branch
from
August 13, 2026 06:00
e1a1423 to
8216e03
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-148
branch
2 times, most recently
from
August 13, 2026 06:39
05f086b to
f90ac2d
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-147
branch
2 times, most recently
from
August 14, 2026 04:46
d29ccde to
ade692c
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-148
branch
3 times, most recently
from
August 14, 2026 05:53
40961bb to
7042fb6
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-148
branch
from
August 28, 2026 11:41
7042fb6 to
e06b8f7
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-148
branch
from
August 29, 2026 12:38
e06b8f7 to
cea62eb
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-147
branch
from
August 29, 2026 12:38
aa44a9b to
974ecff
Compare
fzyzcjy
commented
Aug 30, 2026
fzyzcjy
left a comment
fzyzcjy
left a comment
Collaborator
Author
There was a problem hiding this comment.
No correctness or regression issue introduced by this commit remains at deliver-1. Subsequent return-value and external-data wiring is intentionally supplied by later operations and is outside this operation's scope.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1837