Extract the weight update connection status into ConnStatusManager - #2092
Open
fzyzcjy wants to merge 1 commit into
Open
Extract the weight update connection status into ConnStatusManager#2092fzyzcjy wants to merge 1 commit into
fzyzcjy wants to merge 1 commit into
Conversation
fzyzcjy
requested review from
Shi-Dong,
Zhichenzzz,
maocheng23,
yueming-yuan and
yushengsu-thu
as code owners
August 3, 2026 15:01
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-93
branch
from
August 3, 2026 23:44
92bf705 to
49ea3ff
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-94
branch
2 times, most recently
from
August 4, 2026 00:39
3d87e99 to
b8b6630
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-93
branch
from
August 4, 2026 00:39
49ea3ff to
8373464
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-94
branch
from
August 4, 2026 02:36
b8b6630 to
6367dd2
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-93
branch
2 times, most recently
from
August 4, 2026 06:56
317fd24 to
c7cb5fb
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-94
branch
from
August 4, 2026 06:56
6367dd2 to
1a673a2
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-93
branch
from
August 4, 2026 07:29
c7cb5fb to
67db33f
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-94
branch
from
August 4, 2026 07:29
1a673a2 to
455c8cf
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-93
branch
from
August 4, 2026 07:36
67db33f to
1fe4b83
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-94
branch
from
August 4, 2026 07:36
455c8cf to
bdee610
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-93
branch
from
August 6, 2026 03:49
1fe4b83 to
e6e22bb
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-94
branch
2 times, most recently
from
August 6, 2026 07:04
c1e4ae3 to
ac49f23
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-93
branch
from
August 9, 2026 23:33
1ac168f to
e85b5a4
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-94
branch
2 times, most recently
from
August 10, 2026 00:44
d634602 to
f50283e
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-93
branch
from
August 10, 2026 06:05
ca4f0c9 to
b42a664
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-94
branch
from
August 10, 2026 06:05
f50283e to
d603def
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-93
branch
from
August 10, 2026 16:07
b42a664 to
2bee3d2
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-94
branch
from
August 10, 2026 16:07
d603def to
27c0b1c
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-93
branch
from
August 10, 2026 16:34
2bee3d2 to
d6f19bf
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-94
branch
2 times, most recently
from
August 12, 2026 02:48
2d52fd8 to
673f43d
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-93
branch
from
August 12, 2026 09:32
2d9717b to
fa05891
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-94
branch
6 times, most recently
from
August 13, 2026 03:11
861d65c to
c719e27
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-93
branch
from
August 13, 2026 03:25
3f365ac to
85019eb
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-94
branch
2 times, most recently
from
August 13, 2026 06:01
5533e1d to
d05581b
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-93
branch
from
August 13, 2026 06:01
85019eb to
9aedaeb
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-94
branch
from
August 13, 2026 06:40
d05581b to
dbbfe5d
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-93
branch
from
August 14, 2026 04:45
1162ed9 to
b680915
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-94
branch
from
August 14, 2026 04:46
dbbfe5d to
b22d43e
Compare
guapisolo
approved these changes
Aug 27, 2026
guapisolo
left a comment
guapisolo
left a comment
Collaborator
There was a problem hiding this comment.
Approved in the #1837 stack: #2094 completes the snapshot-aware contract and #2150 normalizes the import ordering before #2176; both remain intact through #2649.
[P2] Non-blocking cross-stack conflict: #2756's own diff does not directly share changed paths, but its stacked base has replaced these updater files and still uses protocol-owned _connection_stale; replaying #2092 fails, and taking the #2756-base side wholesale would lose the post-success reconnect commit, so a failed trainer-stale reconnect could be treated as fresh. When cascading #2756, keep its unified updater but port ConnStatusManager into it and mark reconnected only after protocol.connect() plus _registered_adapters.clear() succeed.
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-93
branch
from
August 29, 2026 12:38
b680915 to
a8aa2b2
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-94
branch
from
August 29, 2026 12:38
b22d43e to
202a4bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1837