Delete the pre-reconcile engine recovery - #2117
Open
fzyzcjy wants to merge 1 commit into
Open
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-110
branch
2 times, most recently
from
August 4, 2026 00:38
ba0c55a to
fd53b66
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-108
branch
from
August 4, 2026 00:38
39b016f to
f5e3ca6
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-110
branch
from
August 4, 2026 02:11
fd53b66 to
f697002
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-108
branch
from
August 4, 2026 02:11
f5e3ca6 to
b2baf2b
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-110
branch
from
August 4, 2026 02:36
f697002 to
f750e27
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-108
branch
from
August 4, 2026 06:53
7904710 to
e0aa5a8
Compare
fzyzcjy
requested review from
Rockdu,
Shi-Dong,
Zhichenzzz,
guapisolo,
jybsuper and
yushengsu-thu
as code owners
August 4, 2026 06:53
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-110
branch
from
August 4, 2026 06:53
f750e27 to
1eb683e
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-108
branch
from
August 4, 2026 07:23
e0aa5a8 to
c45fda1
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-110
branch
from
August 4, 2026 07:23
1eb683e to
5a52103
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-108
branch
from
August 4, 2026 07:31
c45fda1 to
3269f7e
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-110
branch
2 times, most recently
from
August 6, 2026 03:46
479d3eb to
9284d43
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-108
branch
2 times, most recently
from
August 6, 2026 07:04
88d97bc to
86ccce8
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-110
branch
from
August 6, 2026 07:04
9284d43 to
4c99fb4
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-108
branch
from
August 9, 2026 23:31
86ccce8 to
7fbb883
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-110
branch
2 times, most recently
from
August 10, 2026 00:44
0f52cb2 to
ef903fc
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-108
branch
from
August 10, 2026 06:00
d95a148 to
f99cf76
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-110
branch
2 times, most recently
from
August 10, 2026 16:06
525cb4e to
da3afbe
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-108
branch
from
August 10, 2026 16:06
f99cf76 to
a8d6924
Compare
fzyzcjy
changed the base branch from
tom/refactor-miles/op13-108
to
tom/refactor-miles/op13-169
August 10, 2026 16:12
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-110
branch
from
August 10, 2026 16:33
da3afbe to
844f15e
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-169
branch
from
August 10, 2026 16:34
2bc3805 to
485a06d
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-110
branch
from
August 12, 2026 02:48
844f15e to
e5df883
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-169
branch
from
August 12, 2026 09:32
9a6d6ea to
f4928ca
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-110
branch
2 times, most recently
from
August 12, 2026 14:31
e8bb597 to
cd2ec7f
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-169
branch
from
August 12, 2026 14:31
f4928ca to
0805d5d
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-110
branch
from
August 12, 2026 14:36
cd2ec7f to
62f4cb5
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-169
branch
2 times, most recently
from
August 12, 2026 23:56
004ac84 to
a4b5a90
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-110
branch
from
August 12, 2026 23:56
62f4cb5 to
521a301
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-169
branch
from
August 13, 2026 01:13
a4b5a90 to
da75f7b
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-110
branch
from
August 13, 2026 01:13
521a301 to
5fc2428
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-169
branch
from
August 13, 2026 03:11
da75f7b to
7f41563
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-110
branch
from
August 13, 2026 03:11
5fc2428 to
50c238d
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-169
branch
from
August 13, 2026 03:25
7f41563 to
d0940c6
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-110
branch
2 times, most recently
from
August 13, 2026 06:00
1f54921 to
98295a9
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-169
branch
from
August 13, 2026 06:00
d0940c6 to
7c80854
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-110
branch
from
August 13, 2026 06:39
98295a9 to
d0a7495
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-169
branch
from
August 13, 2026 06:39
7c80854 to
1999bff
Compare
recover_updatable_engines restarted dead engines in place before each weight update. Recovery now happens the other way round: the worker manager relaunches a cell, reconcile observes the new generation and re-adds it, and the trainer reconnects because the cell hashes changed. Its rollout_id bookkeeping goes with it, since nothing else read the field.
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-169
branch
from
August 14, 2026 04:45
1999bff to
d399e70
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-110
branch
from
August 14, 2026 04:46
d0a7495 to
8f3f034
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1837