Move per-cell recovery into ServerCell.recover - #1881
Open
fzyzcjy wants to merge 1 commit into
Open
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-17
branch
from
July 28, 2026 13:31
7493517 to
cfe8621
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-23
branch
2 times, most recently
from
August 3, 2026 23:45
92a733e to
a9eb34e
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-17
branch
2 times, most recently
from
August 4, 2026 00:39
1c910b1 to
0e9f0d5
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-23
branch
from
August 4, 2026 00:39
a9eb34e to
04e65d7
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-17
branch
from
August 4, 2026 06:57
0e9f0d5 to
5510389
Compare
fzyzcjy
requested review from
Rockdu,
Shi-Dong,
Zhichenzzz,
guapisolo,
jybsuper and
yushengsu-thu
as code owners
August 4, 2026 06:57
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-23
branch
from
August 4, 2026 06:57
04e65d7 to
975ce31
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-17
branch
2 times, most recently
from
August 10, 2026 06:07
c70d67b to
00bb032
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-23
branch
from
August 10, 2026 06:07
81ebf4e to
c326b1e
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-17
branch
from
August 10, 2026 16:07
00bb032 to
a3a3f81
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-23
branch
from
August 10, 2026 16:34
39948d0 to
9ed4407
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-17
branch
2 times, most recently
from
August 12, 2026 02:48
16f1d68 to
786ee9a
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-23
branch
from
August 12, 2026 14:31
081b08f to
ac37584
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-17
branch
2 times, most recently
from
August 12, 2026 23:56
167d712 to
ff2dd3a
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-23
branch
from
August 13, 2026 01:13
045a39b to
ff36578
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-17
branch
from
August 13, 2026 01:13
ff2dd3a to
68a93b4
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-17
branch
2 times, most recently
from
August 13, 2026 06:01
81fdc60 to
d0044dd
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-23
branch
from
August 13, 2026 06:01
2fb2661 to
ccfb2cc
Compare
Recovering a cell is start + offload/resume + mark alive + publish to the router, all of which act on that one cell, so the whole sequence moves down and the offload policy fields (needs_offload, model_path, update_weights) follow it into ServerCell. ServerGroup.recover becomes a thin parallel fan-out that only decides whether a router is there to register with, and offload/onload gate per cell instead of per group.
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-23
branch
from
August 14, 2026 04:45
ccfb2cc to
d6616bb
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-17
branch
from
August 14, 2026 04:46
d0044dd to
33ff0ae
Compare
guapisolo
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1837