Give each rollout cell a health checker driven by its own state - #2111
Open
fzyzcjy wants to merge 1 commit into
Open
Give each rollout cell a health checker driven by its own state#2111fzyzcjy wants to merge 1 commit into
fzyzcjy wants to merge 1 commit into
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-107
branch
2 times, most recently
from
August 4, 2026 00:38
a78c754 to
87243a2
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-124
branch
from
August 4, 2026 00:38
4c24e17 to
73baef6
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-107
branch
from
August 4, 2026 02:11
87243a2 to
80b0818
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-124
branch
from
August 4, 2026 02:11
73baef6 to
11a8e74
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-107
branch
2 times, most recently
from
August 4, 2026 06:53
f98d091 to
e7de736
Compare
fzyzcjy
requested review from
Rockdu,
Shi-Dong,
Zhichenzzz,
guapisolo,
jybsuper and
yushengsu-thu
as code owners
August 4, 2026 06:53
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-124
branch
from
August 4, 2026 06:53
9bed646 to
eb132aa
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-107
branch
from
August 4, 2026 07:23
e7de736 to
62139ea
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-124
branch
from
August 4, 2026 07:24
eb132aa to
64248ae
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-107
branch
from
August 4, 2026 07:31
62139ea to
d20c76d
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-124
branch
from
August 4, 2026 07:32
64248ae to
eabf509
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-107
branch
from
August 6, 2026 03:46
d20c76d to
eb7b289
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-124
branch
2 times, most recently
from
August 6, 2026 07:04
c7d8a57 to
e7f04f7
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-107
branch
2 times, most recently
from
August 9, 2026 23:31
bc6cdb4 to
5ff9c92
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-124
branch
from
August 9, 2026 23:32
e7f04f7 to
56fa35f
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-107
branch
from
August 10, 2026 00:44
5ff9c92 to
6c5eaf2
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-124
branch
from
August 10, 2026 00:44
56fa35f to
5ec6322
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-107
branch
from
August 10, 2026 06:00
6c5eaf2 to
9683b21
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-124
branch
from
August 10, 2026 06:00
5ec6322 to
9d2851e
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-107
branch
from
August 10, 2026 16:06
9683b21 to
99a6301
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-124
branch
from
August 10, 2026 16:06
9d2851e to
6fc7c64
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-107
branch
3 times, most recently
from
August 12, 2026 09:32
ea9bdc8 to
36261a4
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-124
branch
from
August 12, 2026 14:31
18ebd6a to
d3c5112
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-107
branch
from
August 12, 2026 14:31
36261a4 to
cf0eb56
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-124
branch
from
August 12, 2026 14:36
d3c5112 to
b2ce70e
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-107
branch
2 times, most recently
from
August 12, 2026 23:56
00a29b6 to
aa695d5
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-124
branch
2 times, most recently
from
August 13, 2026 01:13
a8f826b to
86fe756
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-107
branch
from
August 13, 2026 01:13
aa695d5 to
1e109d5
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-124
branch
from
August 13, 2026 03:11
86fe756 to
4c7c8e1
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-107
branch
from
August 13, 2026 03:11
1e109d5 to
1001692
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-124
branch
from
August 13, 2026 03:25
4c7c8e1 to
6bbbe74
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-107
branch
2 times, most recently
from
August 13, 2026 06:00
3aa6eaa to
cc68565
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-124
branch
2 times, most recently
from
August 13, 2026 06:39
cbc0bb0 to
d08abde
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-107
branch
from
August 13, 2026 06:39
cc68565 to
6b10fd9
Compare
Rollout fault tolerance detects a wedged engine in miles itself rather than delegating to a k8s liveness probe: each ServerCell builds a SimpleHealthChecker that probes its engine's /health_generate. Detection only reports status; healing is driven from the outside. Whether that checker should probe is a function of two things, so it is derived rather than driven: the cell must have left StateInitializing (a gated or still booting engine is not listening), and the controller must not have paused probing for an offload or a weight update. The checker therefore starts once, and needs no replay onto cells that reconcile adds mid window. Disposing a cell still stops the checker, since an inactive one keeps polling its predicate forever.
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-107
branch
from
August 14, 2026 04:45
6b10fd9 to
f4420ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1837