Delete the rollout health monitor ahead of its rewrite - #1847
Open
fzyzcjy wants to merge 1 commit into
Open
Conversation
fzyzcjy
requested review from
Shi-Dong,
Zhichenzzz,
guapisolo,
jybsuper,
maocheng23 and
yueming-yuan
as code owners
July 28, 2026 12:55
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
fzyzcjy
force-pushed
the
tom/refactor-miles/op3-13
branch
2 times, most recently
from
August 4, 2026 00:39
8b82317 to
ca33d43
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op2-10
branch
from
August 4, 2026 06:56
57bed4e to
df1a81f
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op3-13
branch
from
August 4, 2026 06:57
ca33d43 to
5d4ad4b
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op2-10
branch
from
August 10, 2026 06:06
df1a81f to
5b39095
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op3-13
branch
2 times, most recently
from
August 10, 2026 16:07
071b915 to
cd73ffc
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op2-10
branch
from
August 10, 2026 16:34
01932a8 to
33f3f0a
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op3-13
branch
from
August 10, 2026 16:34
cd73ffc to
2cf6ebe
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op2-10
branch
from
August 12, 2026 02:48
33f3f0a to
90a799e
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op3-13
branch
from
August 12, 2026 02:48
2cf6ebe to
3ca4644
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op2-10
branch
from
August 12, 2026 14:31
90a799e to
faa9a9c
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op3-13
branch
from
August 12, 2026 14:31
3ca4644 to
8974e1d
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op2-10
branch
from
August 12, 2026 23:56
faa9a9c to
d4f07c3
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op3-13
branch
2 times, most recently
from
August 13, 2026 06:01
492b997 to
3d117b2
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op2-10
branch
from
August 13, 2026 06:01
d4f07c3 to
12fe3b4
Compare
RolloutHealthMonitor was the slime-inherited heartbeat thread; rollout fault tolerance is being rebuilt on the SimpleHealthChecker framework, so remove it now instead of carrying it (and its ray-thread coordination) through the engine refactor. health_monitoring_pause / health_monitoring_resume stay as shells that raise under --use-fault-tolerance, so a run that asks for fault tolerance fails loudly instead of silently going unmonitored, and the call sites keep recording where monitoring has to pause. _try_ci_fault_injection raises for the same reason: it depended on the monitor to observe the crash it injected.
fzyzcjy
force-pushed
the
tom/refactor-miles/op2-10
branch
from
August 14, 2026 04:46
12fe3b4 to
8453d85
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op3-13
branch
from
August 14, 2026 04:46
3d117b2 to
39a45d4
Compare
guapisolo
approved these changes
Aug 24, 2026
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1837