Wait for the expected fleet before the first rollout starts - #2100
Open
fzyzcjy wants to merge 1 commit into
Open
Wait for the expected fleet before the first rollout starts#2100fzyzcjy wants to merge 1 commit into
fzyzcjy wants to merge 1 commit into
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-121
branch
from
August 3, 2026 23:43
3fbd83d to
c192050
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-122
branch
from
August 3, 2026 23:43
920c4c1 to
052a8ba
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-121
branch
from
August 4, 2026 00:38
c192050 to
89d2aa4
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-122
branch
from
August 4, 2026 00:38
052a8ba to
0448dd0
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-121
branch
from
August 4, 2026 02:36
89d2aa4 to
fffc45c
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-122
branch
from
August 4, 2026 02:36
0448dd0 to
7ab173d
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-121
branch
from
August 4, 2026 06:53
fffc45c to
5c39ee8
Compare
fzyzcjy
requested review from
Rockdu,
Shi-Dong,
Zhichenzzz,
guapisolo,
jybsuper and
yushengsu-thu
as code owners
August 4, 2026 06:53
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-122
branch
from
August 4, 2026 06:53
7ab173d to
2cb2d8c
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-121
branch
from
August 4, 2026 07:24
5c39ee8 to
a500bb7
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-122
branch
from
August 4, 2026 07:24
2cb2d8c to
e235047
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-121
branch
from
August 4, 2026 07:31
a500bb7 to
4bd5967
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-122
branch
from
August 4, 2026 07:32
e235047 to
81b07f3
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-121
branch
from
August 6, 2026 03:46
4bd5967 to
06c5f86
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-122
branch
2 times, most recently
from
August 6, 2026 07:04
4ded54c to
d8affc7
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-121
branch
2 times, most recently
from
August 9, 2026 23:31
b1afb84 to
3df9670
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-122
branch
2 times, most recently
from
August 10, 2026 00:44
f770d6a to
ecf01e6
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-121
branch
from
August 10, 2026 06:00
6f041da to
03b5430
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-122
branch
from
August 10, 2026 06:00
ecf01e6 to
d7ccb6e
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-121
branch
from
August 10, 2026 16:06
03b5430 to
bbc7f7d
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-122
branch
2 times, most recently
from
August 10, 2026 16:33
c0f8931 to
cfc6949
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-121
branch
from
August 12, 2026 02:48
007c4f9 to
e8e83eb
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-122
branch
from
August 12, 2026 02:48
cfc6949 to
58db211
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-121
branch
from
August 12, 2026 09:32
e8e83eb to
4c53c2c
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-122
branch
2 times, most recently
from
August 12, 2026 14:31
3f6bf73 to
66ba527
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-121
branch
2 times, most recently
from
August 12, 2026 14:36
1535bc4 to
d1aea9b
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-122
branch
2 times, most recently
from
August 12, 2026 23:56
0223798 to
82acd11
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-121
branch
from
August 13, 2026 01:13
40fa506 to
fe8d3ca
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-122
branch
from
August 13, 2026 01:13
82acd11 to
f2cdafe
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-121
branch
from
August 13, 2026 03:11
fe8d3ca to
66d870b
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-122
branch
2 times, most recently
from
August 13, 2026 03:25
0a097e2 to
d875af9
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-121
branch
from
August 13, 2026 06:00
bed309d to
279e6fa
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-122
branch
from
August 13, 2026 06:00
d875af9 to
22e8ee0
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-121
branch
from
August 13, 2026 06:39
279e6fa to
d19e24f
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-122
branch
2 times, most recently
from
August 14, 2026 04:46
75d2173 to
a522673
Compare
This was referenced Aug 25, 2026
guapisolo
approved these changes
Aug 29, 2026
guapisolo
left a comment
guapisolo
left a comment
Collaborator
There was a problem hiding this comment.
Stack-context approval: [P2] the init test double originally omitted the new startup barrier and would fail stage-a; #2175 adds the method and verifies the barrier blocking/order contract before safe-merge checkpoint #2176. The repair remains present through checked tip #2649, and the initial all-model provisioning barrier itself is intentional.
Starting while most cells are still missing would run the first steps on a fraction of the engines. Block startup until every model reports the number of cells its config asks for: colocated cells only have to exist, while disaggregated ones must already be up, since nothing else waits for them now that cell startup no longer blocks.
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-122
branch
from
August 29, 2026 12:38
a522673 to
dd4cd73
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1837