Cover sglang config parsing with unit tests through resolve_sglang_config - #1991
Open
fzyzcjy wants to merge 1 commit into
Open
Cover sglang config parsing with unit tests through resolve_sglang_config#1991fzyzcjy wants to merge 1 commit into
fzyzcjy wants to merge 1 commit into
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-59
branch
from
August 3, 2026 23:44
031bd02 to
bccd7b9
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-52
branch
from
August 3, 2026 23:44
1bdd045 to
a9ab4f7
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-59
branch
from
August 4, 2026 00:39
bccd7b9 to
fda774d
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-52
branch
from
August 4, 2026 06:54
91b8643 to
545bcf0
Compare
fzyzcjy
requested review from
Rockdu,
Shi-Dong,
Zhichenzzz,
guapisolo,
jybsuper,
maocheng23,
yueming-yuan and
yushengsu-thu
as code owners
August 4, 2026 06:54
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-59
branch
from
August 4, 2026 06:54
fda774d to
21c4c4c
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-52
branch
from
August 4, 2026 07:26
545bcf0 to
cfd2f0e
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-59
branch
from
August 4, 2026 07:26
21c4c4c to
0eec79b
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-52
branch
from
August 4, 2026 07:33
cfd2f0e to
d814d0f
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-59
branch
2 times, most recently
from
August 6, 2026 03:48
6afaba5 to
446a5be
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-52
branch
from
August 6, 2026 07:03
00065c9 to
bdbddc7
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-59
branch
2 times, most recently
from
August 9, 2026 23:32
7ec6011 to
ffef828
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-52
branch
from
August 10, 2026 06:04
bfb0a82 to
2e7de6e
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-59
branch
3 times, most recently
from
August 10, 2026 16:34
ea34878 to
7b22de9
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-52
branch
from
August 12, 2026 02:48
4606f6c to
b406728
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-59
branch
from
August 12, 2026 02:48
7b22de9 to
548ca4c
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-52
branch
from
August 12, 2026 09:32
b406728 to
ca19a39
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-59
branch
2 times, most recently
from
August 12, 2026 14:31
36d01c5 to
7e3ce87
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-52
branch
from
August 12, 2026 14:36
47a6848 to
c922e33
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-59
branch
from
August 12, 2026 14:36
7e3ce87 to
7235393
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-52
branch
from
August 12, 2026 23:56
c922e33 to
9f43231
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-59
branch
from
August 12, 2026 23:56
7235393 to
405986b
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-52
branch
from
August 13, 2026 01:13
9f43231 to
6dc0ec2
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-59
branch
2 times, most recently
from
August 13, 2026 03:11
5aca909 to
99053a0
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-52
branch
from
August 13, 2026 03:25
4e13448 to
ed1c8f5
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-59
branch
from
August 13, 2026 03:25
99053a0 to
b25b8ab
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-52
branch
from
August 13, 2026 06:00
ed1c8f5 to
f0651f5
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-59
branch
2 times, most recently
from
August 13, 2026 06:39
ebefd77 to
c8bab4a
Compare
…nfig The raw/resolved config split lands next; these tests pin the parsing behavior through the stable resolve_sglang_config entry so each step of that refactor can prove it kept the semantics. Direct constructions of ModelConfig/ServerGroupConfig and SglangConfig.from_yaml in tests are migrated to the public entry because the internal API is about to change shape.
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-52
branch
from
August 14, 2026 04:45
9749217 to
c7bf0f4
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-59
branch
from
August 14, 2026 04:46
c8bab4a to
00bf49b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1837