Rename the update weights window entry points to start and end update weights - #2089
Open
fzyzcjy wants to merge 1 commit into
Open
Rename the update weights window entry points to start and end update weights#2089fzyzcjy wants to merge 1 commit into
fzyzcjy wants to merge 1 commit into
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-92
branch
from
August 3, 2026 23:44
aca7df8 to
5fcb381
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-89
branch
from
August 3, 2026 23:44
101caed to
55c28ef
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-92
branch
from
August 4, 2026 00:39
5fcb381 to
a8d50f8
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-89
branch
from
August 4, 2026 02:36
01fe171 to
4f87107
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-92
branch
from
August 4, 2026 02:36
a8d50f8 to
0097edf
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-89
branch
from
August 4, 2026 06:56
4f87107 to
8d08288
Compare
fzyzcjy
requested review from
Rockdu,
Shi-Dong,
Zhichenzzz,
guapisolo,
jybsuper and
yushengsu-thu
as code owners
August 4, 2026 06:56
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-92
branch
from
August 4, 2026 06:56
0097edf to
d1b9ea6
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-89
branch
from
August 4, 2026 07:28
8d08288 to
4083bfb
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-92
branch
from
August 4, 2026 07:28
d1b9ea6 to
344c969
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-89
branch
from
August 4, 2026 07:36
4083bfb to
dfa8690
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-92
branch
from
August 4, 2026 07:36
344c969 to
3c6637c
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-89
branch
from
August 6, 2026 03:49
dfa8690 to
8786d4d
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-92
branch
2 times, most recently
from
August 6, 2026 07:04
53a5d2e to
011228f
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-89
branch
from
August 6, 2026 07:04
8786d4d to
04964cd
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-92
branch
from
August 9, 2026 23:33
011228f to
886624c
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-89
branch
2 times, most recently
from
August 10, 2026 00:44
7ac4e01 to
6265a01
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-92
branch
from
August 10, 2026 00:44
886624c to
46ca272
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-89
branch
from
August 10, 2026 06:05
6265a01 to
bb86134
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-92
branch
from
August 10, 2026 06:05
46ca272 to
7b65e28
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-89
branch
from
August 10, 2026 16:07
bb86134 to
b297b6c
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-92
branch
from
August 10, 2026 16:07
7b65e28 to
03a7183
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-89
branch
from
August 10, 2026 16:34
b297b6c to
4ef3945
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-92
branch
from
August 10, 2026 16:34
03a7183 to
43632e3
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-89
branch
from
August 12, 2026 02:48
4ef3945 to
57ce1ed
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-92
branch
from
August 12, 2026 02:48
43632e3 to
4d5063d
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-89
branch
from
August 12, 2026 09:32
57ce1ed to
ad9afb6
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-92
branch
3 times, most recently
from
August 12, 2026 14:36
de7efa5 to
effa6b1
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-89
branch
2 times, most recently
from
August 12, 2026 23:56
973c34c to
bcddb63
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-92
branch
2 times, most recently
from
August 13, 2026 01:13
a41e0d4 to
9f20ffb
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-89
branch
from
August 13, 2026 03:11
07d917a to
95bf7f3
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-92
branch
2 times, most recently
from
August 13, 2026 03:25
2907c43 to
94639dc
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-89
branch
2 times, most recently
from
August 13, 2026 06:01
8b757a8 to
77524fb
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-92
branch
2 times, most recently
from
August 13, 2026 06:40
5250f50 to
f884633
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-89
branch
from
August 13, 2026 06:40
77524fb to
e4eed7a
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-89
branch
from
August 14, 2026 04:45
e4eed7a to
ce4e1d5
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-92
branch
from
August 14, 2026 04:46
f884633 to
36af919
Compare
guapisolo
approved these changes
Aug 27, 2026
guapisolo
left a comment
guapisolo
left a comment
Collaborator
There was a problem hiding this comment.
[P3] #2089 leaves the fault-tolerance NotImplementedError referring to deleted get_updatable_engines, so anyone diagnosing the guarded FT path is directed to a nonexistent API; #2111 removes that obsolete guard before #2176, and the repair remains present through checked tip #2649. Approved in stack context.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1837