Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docker/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ FROM lmsysorg/sglang:${SGLANG_IMAGE_TAG} AS sglang

# ======================================== Arguments =============================================

ARG SGLANG_BRANCH=sglang-miles-v0.5.15
ARG SGLANG_BRANCH=sglang-miles

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using a floating branch like sglang-miles makes the Docker build non-reproducible. The version of sglang will depend on when the image is built, which can cause unexpected behavior for images tagged as latest or used in production. While this is acceptable for development builds, it's a risk for stable releases.

To improve reproducibility, I'd suggest adding a comment to guide users to pin the dependency using the SGLANG_COMMIT argument for stable builds.

# The sglang-miles branch is a development branch. For reproducible builds, set SGLANG_COMMIT to a specific commit hash.
ARG SGLANG_BRANCH=sglang-miles

ARG SGLANG_COMMIT=""

ARG MEGATRON_REPO=radixark/Megatron-LM
Expand Down
Loading