Skip to content

Point SGLANG_BRANCH back to sglang-miles - #1701

Merged
yueming-yuan merged 1 commit into
mainfrom
fix_sglang_branch_pointer
Jul 16, 2026
Merged

Point SGLANG_BRANCH back to sglang-miles#1701
yueming-yuan merged 1 commit into
mainfrom
fix_sglang_branch_pointer

Conversation

@yueming-yuan

Copy link
Copy Markdown
Collaborator

sglang-miles has been repointed to the v0.5.15 stack (same commit as sglang-miles-v0.5.15, 5bca6f8). Restore the default branch reference before the transitional sglang-miles-v0.5.15 branch is deleted.

sglang-miles now carries the v0.5.15 stack; the transitional
sglang-miles-v0.5.15 branch will be deleted.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the SGLANG_BRANCH in the Dockerfile to use the sglang-miles branch. The reviewer noted that using a floating branch can negatively impact build reproducibility and suggested adding a comment to guide users to pin the SGLANG_COMMIT for stable, production-ready builds.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread docker/Dockerfile
# ======================================== Arguments =============================================

ARG SGLANG_BRANCH=sglang-miles-v0.5.15
ARG SGLANG_BRANCH=sglang-miles

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using a floating branch like sglang-miles makes the Docker build non-reproducible. The version of sglang will depend on when the image is built, which can cause unexpected behavior for images tagged as latest or used in production. While this is acceptable for development builds, it's a risk for stable releases.

To improve reproducibility, I'd suggest adding a comment to guide users to pin the dependency using the SGLANG_COMMIT argument for stable builds.

# The sglang-miles branch is a development branch. For reproducible builds, set SGLANG_COMMIT to a specific commit hash.
ARG SGLANG_BRANCH=sglang-miles

@guapisolo guapisolo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@yueming-yuan
yueming-yuan merged commit aac8307 into main Jul 16, 2026
27 of 37 checks passed
@yueming-yuan
yueming-yuan deleted the fix_sglang_branch_pointer branch July 16, 2026 19:11
@yueming-yuan yueming-yuan mentioned this pull request Jul 25, 2026
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants