Point SGLANG_BRANCH back to sglang-miles - #1701
Conversation
sglang-miles now carries the v0.5.15 stack; the transitional sglang-miles-v0.5.15 branch will be deleted.
There was a problem hiding this comment.
Code Review
This pull request updates the SGLANG_BRANCH in the Dockerfile to use the sglang-miles branch. The reviewer noted that using a floating branch can negatively impact build reproducibility and suggested adding a comment to guide users to pin the SGLANG_COMMIT for stable, production-ready builds.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| # ======================================== Arguments ============================================= | ||
|
|
||
| ARG SGLANG_BRANCH=sglang-miles-v0.5.15 | ||
| ARG SGLANG_BRANCH=sglang-miles |
There was a problem hiding this comment.
Using a floating branch like sglang-miles makes the Docker build non-reproducible. The version of sglang will depend on when the image is built, which can cause unexpected behavior for images tagged as latest or used in production. While this is acceptable for development builds, it's a risk for stable releases.
To improve reproducibility, I'd suggest adding a comment to guide users to pin the dependency using the SGLANG_COMMIT argument for stable builds.
# The sglang-miles branch is a development branch. For reproducible builds, set SGLANG_COMMIT to a specific commit hash.
ARG SGLANG_BRANCH=sglang-miles
sglang-miles has been repointed to the v0.5.15 stack (same commit as sglang-miles-v0.5.15,
5bca6f8). Restore the default branch reference before the transitionalsglang-miles-v0.5.15branch is deleted.