Skip to content

fix rose deployment #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix rose deployment #71

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
062711c
fix rose deployment
andre-merzky Oct 23, 2025
9dec067
Merge branch 'main' into fix/deployment
andre-merzky Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,9 @@ markers = [
"integration: marks tests as integration tests",
]

[tool.setuptools.packages.find]
where = ["rose"]
Copy link

Copilot AI Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The where parameter should point to the directory containing the package, not the package itself. If 'rose' is the package name, where should be ["."] (the project root) or omitted entirely. If the package is inside a src/ directory, use where = ["src"]. The current configuration will look for packages inside the rose directory, which is likely incorrect.

Suggested change
where = ["rose"]
where = ["."]

Copilot uses AI. Check for mistakes.
Comment on lines +72 to +73
Copy link

@gemini-code-assist gemini-code-assist bot Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using where = ["rose"] suggests an unconventional project layout where the source directory is named the same as the package (rose). This can be confusing for developers. A more common convention in Python projects is to use a src layout, where all source code resides in a src directory. Adopting this convention would mean restructuring the project to have src/rose/... and changing this configuration to where = ["src"]. While this is a larger change outside the scope of this PR, it's a good practice to consider for improving project clarity and long-term maintainability.


[tool.coverage.run]
source = ["rose"]
omit = ["tests/*"]
Expand Down
Loading