-
Notifications
You must be signed in to change notification settings - Fork 1
fix rose deployment #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @andre-merzky, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a deployment problem by modifying the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes rose deployment issues by adding setuptools package discovery configuration to ensure the rose package is properly found and packaged during installation.
- Adds
[tool.setuptools.packages.find]section to specify package location
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| ] | ||
|
|
||
| [tool.setuptools.packages.find] | ||
| where = ["rose"] |
Copilot
AI
Oct 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The where parameter should point to the directory containing the package, not the package itself. If 'rose' is the package name, where should be ["."] (the project root) or omitted entirely. If the package is inside a src/ directory, use where = ["src"]. The current configuration will look for packages inside the rose directory, which is likely incorrect.
| where = ["rose"] | |
| where = ["."] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request fixes the package deployment by configuring setuptools to correctly find the rose package. The change is functional and addresses the issue. I have added one comment regarding project structure conventions that could improve long-term maintainability by making the project layout more intuitive for developers.
| [tool.setuptools.packages.find] | ||
| where = ["rose"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using where = ["rose"] suggests an unconventional project layout where the source directory is named the same as the package (rose). This can be confusing for developers. A more common convention in Python projects is to use a src layout, where all source code resides in a src directory. Adopting this convention would mean restructuring the project to have src/rose/... and changing this configuration to where = ["src"]. While this is a larger change outside the scope of this PR, it's a good practice to consider for improving project clarity and long-term maintainability.
This PR fixes #66.