-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DO NOT MERGE Try to get logs for flakes #12519
Open
dcorbacho
wants to merge
9
commits into
main
Choose a base branch
from
trigger-ci-flake
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+143
−496
Commits on Nov 25, 2024
-
rabbit_peer_discovery: Remove the use of group leader proxy
[Why] This was the first solution put in place to prevent that the temporary hidden node connects to the node that started it to write any printed messages. Because of this, the nodes that the temporary hidden node queried found out about the parent node and they opened an Erlang distribution connection to it. This polluted the known nodes list. However later, the temporary hidden node was started with the `standard_io` connection option. This prevented the temporary hidden node from knowing about the node that started it, solving the problem in a cleaner way. [How] This commit garbage-collects that piece of code that is now useless. It makes the query code way simpler to understand.
Configuration menu - View commit details
-
Copy full SHA for b8c096f - Browse repository at this point
Copy the full SHA b8c096fView commit details -
rabbit_peer_discovery: Fix non-tail-recursive
query_node_props2()
[Why] This impacts what is reported by the catch because it caught exceptions emitted by code supposedly called later. An example is the assert in `query_node_props2/3` last clause.
Configuration menu - View commit details
-
Copy full SHA for 9aa1f34 - Browse repository at this point
Copy the full SHA 9aa1f34View commit details -
rabbit_peer_discovery: Retry RPC calls
[Why] In CI, we observe some timeouts in the Erlang distribution connections between the temporary hidden node and the nodes it queries. This affects peer discovery obviously. [How] We introduce some query retries to reduce the risk of an incomplete query. While here, we move the sorting of queried nodes from the `query_node_props2/3` last clause (executed in the temporary hidden node) to the function setting the temporary hidden node and asking for these queries. This way the debug messages from that sorting are logged by RabbitMQ out of the box.
Configuration menu - View commit details
-
Copy full SHA for c7d3a9f - Browse repository at this point
Copy the full SHA c7d3a9fView commit details -
Configuration menu - View commit details
-
Copy full SHA for f8d30a6 - Browse repository at this point
Copy the full SHA f8d30a6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 473b8e6 - Browse repository at this point
Copy the full SHA 473b8e6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3bd07c4 - Browse repository at this point
Copy the full SHA 3bd07c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 573bb2c - Browse repository at this point
Copy the full SHA 573bb2cView commit details
Commits on Nov 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0244671 - Browse repository at this point
Copy the full SHA 0244671View commit details
Commits on Nov 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f8c7845 - Browse repository at this point
Copy the full SHA f8c7845View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.