Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE Try to get logs for flakes #12519

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Commits on Nov 25, 2024

  1. rabbit_peer_discovery: Remove the use of group leader proxy

    [Why]
    This was the first solution put in place to prevent that the temporary
    hidden node connects to the node that started it to write any printed
    messages. Because of this, the nodes that the temporary hidden node
    queried found out about the parent node and they opened an Erlang
    distribution connection to it. This polluted the known nodes list.
    
    However later, the temporary hidden node was started with the
    `standard_io` connection option. This prevented the temporary hidden
    node from knowing about the node that started it, solving the problem in
    a cleaner way.
    
    [How]
    This commit garbage-collects that piece of code that is now useless. It
    makes the query code way simpler to understand.
    dumbbell authored and dcorbacho committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    b8c096f View commit details
    Browse the repository at this point in the history
  2. rabbit_peer_discovery: Fix non-tail-recursive query_node_props2()

    [Why]
    This impacts what is reported by the catch because it caught exceptions
    emitted by code supposedly called later. An example is the assert
    in `query_node_props2/3` last clause.
    dumbbell authored and dcorbacho committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    9aa1f34 View commit details
    Browse the repository at this point in the history
  3. rabbit_peer_discovery: Retry RPC calls

    [Why]
    In CI, we observe some timeouts in the Erlang distribution connections
    between the temporary hidden node and the nodes it queries. This affects
    peer discovery obviously.
    
    [How]
    We introduce some query retries to reduce the risk of an incomplete
    query.
    
    While here, we move the sorting of queried nodes from the
    `query_node_props2/3` last clause (executed in the temporary hidden
    node) to the function setting the temporary hidden node and asking for
    these queries. This way the debug messages from that sorting are logged
    by RabbitMQ out of the box.
    dumbbell authored and dcorbacho committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    c7d3a9f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f8d30a6 View commit details
    Browse the repository at this point in the history
  5. Run just a subset of suites

    dcorbacho committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    473b8e6 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    3bd07c4 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    573bb2c View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2024

  1. Configuration menu
    Copy the full SHA
    0244671 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2024

  1. Configuration menu
    Copy the full SHA
    f8c7845 View commit details
    Browse the repository at this point in the history