DO NOT MERGE Try to get logs for flakes #12519
Open
+143
−496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcorbacho
force-pushed
the
trigger-ci-flake
branch
7 times, most recently
from
583d13c
to
9c4dce9
Compare
dcorbacho
force-pushed
the
trigger-ci-flake
branch
from
9c4dce9
to
3df9675
Compare
dcorbacho
force-pushed
the
trigger-ci-flake
branch
5 times, most recently
from
d8c4417
to
8905177
Compare
dcorbacho
force-pushed
the
trigger-ci-flake
branch
8 times, most recently
from
8f228d3
to
58f3425
Compare
dcorbacho
force-pushed
the
trigger-ci-flake
branch
7 times, most recently
from
73f9569
to
4b43ca7
Compare
dcorbacho
force-pushed
the
trigger-ci-flake
branch
2 times, most recently
from
c0d7ecf
to
b96742b
Compare
[Why] This was the first solution put in place to prevent that the temporary hidden node connects to the node that started it to write any printed messages. Because of this, the nodes that the temporary hidden node queried found out about the parent node and they opened an Erlang distribution connection to it. This polluted the known nodes list. However later, the temporary hidden node was started with the `standard_io` connection option. This prevented the temporary hidden node from knowing about the node that started it, solving the problem in a cleaner way. [How] This commit garbage-collects that piece of code that is now useless. It makes the query code way simpler to understand.
[Why] This impacts what is reported by the catch because it caught exceptions emitted by code supposedly called later. An example is the assert in `query_node_props2/3` last clause.
[Why] In CI, we observe some timeouts in the Erlang distribution connections between the temporary hidden node and the nodes it queries. This affects peer discovery obviously. [How] We introduce some query retries to reduce the risk of an incomplete query. While here, we move the sorting of queried nodes from the `query_node_props2/3` last clause (executed in the temporary hidden node) to the function setting the temporary hidden node and asking for these queries. This way the debug messages from that sorting are logged by RabbitMQ out of the box.
dcorbacho
force-pushed
the
trigger-ci-flake
branch
from
b96742b
to
573bb2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.