feat(nfts + nonfungibles): sync polkadot stable2503

[chungquantin]

This PR syncs all changes from v1.15.0 to polkadot-stable2503 for the pallet-nfts and pallet-nonfugibles

• from polkadot-v1.15.0: paritytech/polkadot-sdk@7ecf3f7 

• to polkadot-stable2503: paritytech/polkadot-sdk@0c0d4ce

Requires rebasing to this commit on main.

Related upstream commits:

Commit comments are identical to the commits in pallet-nfts | stable2503

• fix visibility for pallet_nfts types used as call arguments
• [pallet-nfts, pallet_uniques] - Expose private structs: Make all types of pallet-nfts public. With this change, we need to consider making changes to the pallet-nonfungibles as it was a blocker before (maybe not needed, just note it here)
• Adds BlockNumberProvider in multisig, proxy and nft pallets: This commit simply removes frame_system::pallet_prelude::BlockNumberFor and replaces it with type BlockNumberProvider configured on the runtime side.
  • Changes made to the Config trait of both pallet-nfts and pallet-nonfungibles
  • Replaces all BlockNumberFor<T> with BlockNumberFor<T, I>
• Removed unused dependencies (partial progress): Removes pallet-nfts from runtime-api as it is not used by the crate.
• implement DecodeWithMemTracking for frame pallets: Add DecodeWithMemTracking to most of the types in pallet-nfts. (UPDATED: This PR no longer contains this commit as it has been updated in 2372731#diff-c20a7ad3d8fa1d073ced5bb90e6dd70a357679adfd05c562478a10e4c55b733e)

[chungquantin]

[sc-3710]

[codecov-commenter]

Codecov Report

❌ Patch coverage is 9.05512% with 462 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.44%. Comparing base (8e5c719) to head (1bc0974).
⚠️ Report is 9 commits behind head on main.

Files with missing lines	Patch %	Lines
pallets/nfts/src/weights.rs	5.85%	450 Missing ⚠️
pallets/nfts/src/types.rs	0.00%	12 Missing ⚠️

@@            Coverage Diff             @@
##             main     #558      +/-   ##
==========================================
- Coverage   63.56%   63.44%   -0.13%     
==========================================
  Files         121      121              
  Lines       23801    23850      +49     
  Branches    23801    23850      +49     
==========================================
+ Hits        15129    15131       +2     
- Misses       7628     7675      +47     
  Partials     1044     1044              

Files with missing lines	Coverage Δ
pallets/api/src/mock.rs	74.46% <ø> (ø)
pallets/api/src/nonfungibles/mod.rs	95.80% <ø> (ø)
pallets/api/src/nonfungibles/weights.rs	50.00% <ø> (ø)
pallets/nfts/src/features/approvals.rs	97.11% <100.00%> (ø)
pallets/nfts/src/features/atomic_swap.rs	90.84% <100.00%> (+0.06%)	⬆️
pallets/nfts/src/features/attributes.rs	86.97% <100.00%> (ø)
pallets/nfts/src/features/create_delete_item.rs	88.46% <100.00%> (ø)
pallets/nfts/src/features/settings.rs	87.67% <100.00%> (-0.65%)	⬇️
pallets/nfts/src/lib.rs	69.69% <100.00%> (ø)
pallets/nfts/src/mock.rs	93.75% <ø> (ø)
... and 4 more

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[al3mart]

Awesome! It looks great!

I've left one comment to clarify if we really need BlockNumberProvider in the api.
Given that we are using
type BlockNumberFor<T> = pallet_nfts::BlockNumberFor<T, NftsInstanceOf<T>>; it seems that we could be good without adding a new type to the trait ?

Once that is clarified I'm happy to approve 👌

[Daanvdplas]

Looking good, two nitpicks but nothing to stop this from going in.

[al3mart]

Awesome, thanks!

The base branch was changed.

[al3mart]

Looks great!

Only one nit. I believe there's some more cases (at least one) of frame_system::Pallet::<T>::block_number(); within benchmarking.rs that could be substituted for T::BlockNumberProvider::current_block_number();

[al3mart]

Meant to request changes 😅

[chungquantin]

chore: benchmarking replace with BlockNumberProvider

Thanks Ale, great catch! I have resolved it in 986a3b4

[al3mart]

Awesome, @chungquantin! Thanks