Expose vec_names2(), vec_names() and vec_set_names() #1173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed for: - tidyverse/tibble#797 - tidyverse/tibble#738 - tidyverse/tibble#730 and perhaps more.
lionel-
reviewed
Jul 6, 2020
R/names.R
Outdated
| #' Returns the repaired names from a vector, even if the vector is unnamed. | ||
| #' @description | ||
| #' These functions work like [rlang::names2()], [names()] and [names<-()], | ||
| #' except that they return or modify the conceptual names of the vector. |
There was a problem hiding this comment.
the rowwise names of the vector. These are:
- The usual
names()for atomic vectors and lists - The row names for data frames and matrices
- The names of the first dimension for arrays
There was a problem hiding this comment.
Excuse the drive-by comment, but what is meant by "conceptual" names? If that term is defined and used elsewhere and I just don't have enough context, then never mind.
There was a problem hiding this comment.
Agreed this is not a defined term. I'm suggesting to replace "conceptual" by "rowwise", which seems clearer?
There was a problem hiding this comment.
I think since it is so related to the vctrs concept of size, they could be called "size consistent names"
DavisVaughan
approved these changes
Jul 6, 2020
R/names.R
Outdated
| #' `vec_names()` is a bare-bones version that returns `NULL` if the vector is | ||
| #' unnamed. | ||
| #' | ||
| #' `vec_set_names()` sets the names. |
There was a problem hiding this comment.
Perhaps a note that you can set names to NULL to remove them?
Co-authored-by: Davis Vaughan <[email protected]> Co-authored-by: Lionel Henry <[email protected]>
|
Thanks for the feedback! |
lionel-
approved these changes
Jul 6, 2020
Comment on lines
+204
to
+205
| #' Rowwise names are size consistent: the length of the names always equals | ||
| #' [vec_size()]. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for:
and perhaps more.