Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enframe() should check vec_is() #730

Closed
krlmlr opened this issue Mar 12, 2020 · 1 comment · Fixed by #904
Closed

enframe() should check vec_is() #730

krlmlr opened this issue Mar 12, 2020 · 1 comment · Fixed by #904
Labels
vctrs ↗️ Requires vctrs package
Milestone
3.1.3

Comments

@krlmlr
Copy link
Member

krlmlr commented Mar 12, 2020

and not the number of dimensions.

tibble::enframe(iris)
#> Error: `x` must not have more than one dimension. `length(dim(x))` must be zero or one, not 2.

Created on 2020-03-12 by the reprex package (v0.3.0)
@krlmlr krlmlr added the reprex needs a minimal reproducible example label Mar 12, 2020
@krlmlr krlmlr added vctrs ↗️ Requires vctrs package and removed reprex needs a minimal reproducible example labels Mar 20, 2020
@krlmlr krlmlr mentioned this issue Mar 20, 2020
Closed
@krlmlr krlmlr added this to the 3.1.0 milestone Mar 21, 2020
@krlmlr krlmlr modified the milestone: 3.1.0 Jul 4, 2020
krlmlr added a commit to r-lib/vctrs that referenced this issue Jul 6, 2020
@krlmlr
Expose vec_names2(), vec_names() and vec_set_names()
f894a84 
Needed for:

- tidyverse/tibble#797
- tidyverse/tibble#738
- tidyverse/tibble#730

and perhaps more.
@krlmlr krlmlr mentioned this issue Jul 6, 2020
Merged
krlmlr added a commit to r-lib/vctrs that referenced this issue Jul 6, 2020
@krlmlr
Expose vec_names2(), vec_names() and vec_set_names()
75bb919 
Needed for:

- tidyverse/tibble#797
- tidyverse/tibble#738
- tidyverse/tibble#730

and perhaps more.
lionel- pushed a commit to r-lib/vctrs that referenced this issue Jul 6, 2020
@krlmlr
Expose vec_names2(), vec_names() and vec_set_names() (#1173)
7a86784 
Needed for:

- tidyverse/tibble#797
- tidyverse/tibble#738
- tidyverse/tibble#730
@krlmlr krlmlr modified the milestones: 3.1.0, 3.1.1 Feb 23, 2021
@krlmlr krlmlr modified the milestones: 3.1.1, 3.1.2 Apr 16, 2021
@krlmlr krlmlr modified the milestones: 3.1.2, 3.1.3 Jul 17, 2021
@krlmlr krlmlr mentioned this issue Jul 20, 2021
Merged
krlmlr added a commit that referenced this issue Jul 20, 2021
@krlmlr
Merge pull request #904 from tidyverse/f-730-enframe-vec-2
46f03f3 
- `enframe()` and `deframe()` support arbitrary vectors (#730).
@github-actions
Copy link
Contributor

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
vctrs ↗️ Requires vctrs package
Projects
None yet
Milestone
3.1.3
1 participant
@krlmlr