Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: useComputed$ double read #997

Closed

Conversation

thejackshelton
Copy link
Collaborator

@thejackshelton thejackshelton commented Oct 16, 2024

In v2 combobox and dropdown break because of a computed that does a signal read of another computed.

This works as a workaround (but is also more efficient) to the bug in v2.

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests
  • Other

Why is it needed?

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have ran pnpm change and documented my changes
  • I have add necessary docs (if needed)
  • Added new tests to cover the fix / functionality

Copy link

changeset-bot bot commented Oct 16, 2024

⚠️ No Changeset found

Latest commit: 34925b7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Oct 16, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/qwikifiers/qwik-ui@997
pnpm add https://pkg.pr.new/qwikifiers/qwik-ui/@qwik-ui/styled@997
pnpm add https://pkg.pr.new/qwikifiers/qwik-ui/@qwik-ui/headless@997
pnpm add https://pkg.pr.new/qwikifiers/qwik-ui/@qwik-ui/utils@997

commit: 34925b7

@thejackshelton
Copy link
Collaborator Author

fixed in v2 so this workaround is no longer needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant