Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configurable job class #6

Closed
wants to merge 3 commits into from
Closed

Configurable job class #6

wants to merge 3 commits into from

Commits on May 11, 2016

  1. Set the object name for each job, to make it clear which job has failed 

    And we don't need two log lines for timeouts.
    @KitsuneRal
    KitsuneRal committed May 11, 2016
    Configuration menu
    Copy the full SHA
    b4a2955 View commit details
    Browse the repository at this point in the history

  2. Minor refactoring 

    1. Deduplicate the code creating SyncRoomData structures for different join states.
2. Use anonymous struct instead of QPair<> to improve code readability.
    @KitsuneRal
    KitsuneRal committed May 11, 2016
    Configuration menu
    Copy the full SHA
    c26ce32 View commit details
    Browse the repository at this point in the history

  3. SimpleJob class introduced 

    This class encapsulates a simple case when the job result doesn't generate Event* objects. In such cases a SimpleJob descendant won't need to implement parseJson() - instead, it's enough to specify expected result items through SimpleJob::ResultItem<> template. The implementation is backwards compatible - in this commit, PasswordLogin result parsing has been completely rewritten with ResultItem<> without affecting PasswordLogin clients; and RoomMessagesJob partially used ResultItem while still parsing the event list in the class. Support of non-toplevel JSON keys and complex objects (think QList<Event*>) is in the pipeline.
    @KitsuneRal
    KitsuneRal committed May 11, 2016
    Configuration menu
    Copy the full SHA
    5b566c3 View commit details
    Browse the repository at this point in the history