Configurable job class #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And we don't need two log lines for timeouts.
1. Deduplicate the code creating SyncRoomData structures for different join states. 2. Use anonymous struct instead of QPair<> to improve code readability.
This class encapsulates a simple case when the job result doesn't generate Event* objects. In such cases a SimpleJob descendant won't need to implement parseJson() - instead, it's enough to specify expected result items through SimpleJob::ResultItem<> template. The implementation is backwards compatible - in this commit, PasswordLogin result parsing has been completely rewritten with ResultItem<> without affecting PasswordLogin clients; and RoomMessagesJob partially used ResultItem while still parsing the event list in the class. Support of non-toplevel JSON keys and complex objects (think QList<Event*>) is in the pipeline.
|
Looks like I've found a more flexible way using a pImpl idiom. Expect a considerable rewrite of the last commit. |
|
No more relevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, here it comes - a class that can facilitate creating new jobs. It's not that you can write SimpleJob(some,construction,configuration) and magically get support of one more action - but I suppose it wouldn't be quite readable anyway. Kindly consider, along with a usual dose of code cleanup (actually, all the interesting stuff is in the last commit).