Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Codestarts - Do not reference ITs module if extension without ITs #44141

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Codestarts - Do not reference ITs module if extension without ITs #44141

merged 1 commit into from
Oct 29, 2024

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Oct 28, 2024

When creating a project without ITs, we don't generate the ITs module so we shouldn't reference it in the parent POM.

Fixes #37216

@gsmet
Codestarts - Do not reference ITs module if extension without ITs
a09e715 
When creating a project without ITs, we don't generate the ITs module so
we shouldn't reference it in the parent POM.

Fixes quarkusio#37216
@gsmet gsmet mentioned this pull request Oct 28, 2024
Closed
@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform labels Oct 28, 2024
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Oct 28, 2024 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit a09e715.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@gsmet gsmet requested a review from ia3andy October 29, 2024 07:50
ia3andy
ia3andy approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@ia3andy ia3andy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gsmet gsmet merged commit f7930ce into quarkusio:main Oct 29, 2024
52 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.17 - main milestone Oct 29, 2024
@gsmet gsmet modified the milestones: 3.17 - main, 3.16.1 Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ia3andy ia3andy ia3andy approved these changes

Assignees
No one assigned
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform kind/bugfix
Projects
None yet
Milestone
3.16.1
Development

Successfully merging this pull request may close these issues.

Building my first extension missing test result in failure
2 participants
@gsmet @ia3andy