Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building my first extension missing test result in failure #37216

Closed
maxandersen opened this issue Nov 20, 2023 · 10 comments · Fixed by #44141
Closed

Building my first extension missing test result in failure #37216

maxandersen opened this issue Nov 20, 2023 · 10 comments · Fixed by #44141
Assignees
Labels
area/documentation kind/bug Something isn't working
Milestone

Comments

@maxandersen
Copy link
Member

Describe the bug

running:

mvn io.quarkus.platform:quarkus-maven-plugin:3.5.2:create-extension -N -DgroupId=io.quarkiverse.code-server -DextensionId=code-server -DwithoutTests

as documented in https://quarkus.io/guides/building-my-first-extension results in the project build failing:

mvn install
Using maven at '/Users/manderse/.sdkman/candidates/mvnd/current/bin/mvnd' to run buildFile '/Users/manderse/code/quarkus-code-server/pom.xml':
Nov 20, 2023 1:09:00 PM org.jline.utils.Log logr
WARNING: Unable to create a system terminal, creating a dumb terminal (enable debug logging for more information)
[main] WARN org.jline - Unable to create a system terminal, creating a dumb terminal (enable debug logging for more information)
[INFO] Processing build on daemon 6aea3359
[INFO] Scanning for projects...
[ERROR] [ERROR] Some problems were encountered while processing the POMs:
[ERROR] Child module /Users/manderse/code/quarkus-code-server/integration-tests of /Users/manderse/code/quarkus-code-server/pom.xml does not exist @
 @
[ERROR] The build could not read 1 project -> [Help 1]
[ERROR]
[ERROR]   The project io.quarkiverse.code-server:quarkus-code-server-parent:999-SNAPSHOT (/Users/manderse/code/quarkus-code-server/pom.xml) has 1 error
[ERROR]     Child module /Users/manderse/code/quarkus-code-server/integration-tests of /Users/manderse/code/quarkus-code-server/pom.xml does not exist
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException

Expected behavior

that getting started docs does not suggest create project that does not build :)

Actual behavior

No response

How to Reproduce?

No response

Output of uname -a or ver

No response

Output of java -version

No response

Quarkus version or git rev

No response

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

@maxandersen maxandersen added the kind/bug Something isn't working label Nov 20, 2023
@maxandersen
Copy link
Member Author

also the generated app is using 999-SNAPSHOT but docs says 1.0.0-SNAPSHOT

@gsmet
Copy link
Member

gsmet commented Nov 20, 2023

I fixed a few broken things there already lately. I will have a look.

@gsmet gsmet self-assigned this Nov 20, 2023
@gsmet
Copy link
Member

gsmet commented Nov 20, 2023

I would argue that you shouldn't be surprised that your extension is broken if you don't have tests in it :]

@maxandersen
Copy link
Member Author

@gsmet totally - hence I was surprised we didn't generated test by default.

Other thing that we should have is -DextensionDescription="Do something useful." as otherwise you create extensions that has quarkiverse description :)

@gsmet
Copy link
Member

gsmet commented Nov 20, 2023

Yeah so FYI, I have on my TODO to improve this guide with some Quarkiverse stuff (or to write a specific guide targeting Quarkiverse).

We need the Quarkiverse way to be the easiest one.

Copy link

quarkus-bot bot commented Nov 20, 2023

/cc @MichalMaler (documentation), @ebullient (documentation), @inoxx03 (documentation), @michelle-purcell (documentation), @rolfedh (documentation), @sheilamjones (documentation), @sunayna15 (documentation)

@holly-cummins
Copy link
Contributor

Yeah so FYI, I have on my TODO to improve this guide with some Quarkiverse stuff (or to write a specific guide targeting Quarkiverse).

We need the Quarkiverse way to be the easiest one.

There's also https://hub.quarkiverse.io, which is I think a natural place for some? most? of the quarkiverse content, but we need to improve the cross-linking back and forth.

@gsmet
Copy link
Member

gsmet commented Nov 20, 2023

@holly-cummins yeah, makes sense. I'll take your comment into account.

@holly-cummins
Copy link
Contributor

Aha! I knew I'd tripped across the opposite problem, but I couldn't find any trace of it. It's this issue: #29158. So I still can't find the change that did it, but it looks like #29158 was fixed (but not closed), and that created #37216?

@gsmet
Copy link
Member

gsmet commented Oct 28, 2024

I created #44141 to fix it.

@gsmet gsmet changed the title builidng my first extension missing test result in failure Building my first extension missing test result in failure Oct 28, 2024
@github-project-automation github-project-automation bot moved this from To do to Done in Quarkus Documentation Oct 29, 2024
@quarkus-bot quarkus-bot bot added this to the 3.17 - main milestone Oct 29, 2024
@gsmet gsmet modified the milestones: 3.17 - main, 3.16.1 Oct 29, 2024
gsmet added a commit to gsmet/quarkus that referenced this issue Oct 29, 2024
When creating a project without ITs, we don't generate the ITs module so
we shouldn't reference it in the parent POM.

Fixes quarkusio#37216

(cherry picked from commit a09e715)
bschuhmann pushed a commit to bschuhmann/quarkus that referenced this issue Nov 16, 2024
When creating a project without ITs, we don't generate the ITs module so
we shouldn't reference it in the parent POM.

Fixes quarkusio#37216
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation kind/bug Something isn't working
Projects
Development

Successfully merging a pull request may close this issue.

4 participants