Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable instrumentation according with SDK config #43535

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

brunobat
Copy link
Contributor

@brunobat brunobat commented Sep 26, 2024

Fixes #43502

Copy link

quarkus-bot bot commented Sep 26, 2024

/cc @radcortez (opentelemetry)

@brunobat
Copy link
Contributor Author

This could be a candidate to backport, but not in the next minor because I want to have it in the wild for a bit, @gsmet.

This comment has been minimized.

@brunobat brunobat force-pushed the 43502-deactivate-instrumentation branch from 2e6c5fa to 5191a63 Compare September 26, 2024 15:46

This comment has been minimized.

@brunobat brunobat force-pushed the 43502-deactivate-instrumentation branch from 5191a63 to 6ccff48 Compare September 26, 2024 16:02
Copy link

quarkus-bot bot commented Sep 26, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 6ccff48.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17 Windows

📦 integration-tests/smallrye-graphql

io.quarkus.it.smallrye.graphql.MicrometerMetricsTest.shouldCreateMultipleMetrics - History

  • 1 expectation failed. Response body doesn't match expectation. Expected: a string containing "mp_graphql_seconds_count{name=\"asyncSuperMetricFoo\",source=\"false\",type=\"QUERY\"} 200" Actual: \# TYPE mp_graphql_seconds summary \# HELP mp_graphql_seconds - java.lang.AssertionError
java.lang.AssertionError: 
1 expectation failed.
Response body doesn't match expectation.
Expected: a string containing "mp_graphql_seconds_count{name=\"asyncSuperMetricFoo\",source=\"false\",type=\"QUERY\"} 200"
  Actual: # TYPE mp_graphql_seconds summary
# HELP mp_graphql_seconds  
mp_graphql_seconds_count{name="clearMetrics",source="false",type="MUTATION"} 1.0
mp_graphql_seconds_sum{name="clearMetrics",source="false",type="MUTATION"} 6.635E-4

@brunobat brunobat merged commit 96d8967 into quarkusio:main Sep 30, 2024
27 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.16 - main milestone Sep 30, 2024
@brunobat
Copy link
Contributor Author

@gsmet added this one for backport

@gsmet gsmet modified the milestones: 3.16.0.CR1, 3.15.2 Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenTelemetry instrumentation still active after quarkus.otel.sdk.disabled=true
3 participants