-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenTelemetry instrumentation still active after quarkus.otel.sdk.disabled=true
#43502
Comments
|
Seems like something we should fix for |
@brunobat triage/backport* labels may not be added to an issue. Please add them to the corresponding pull request. This message is automatically generated by a bot. |
@brunobat triage/backport* labels may not be added to an issue. Please add them to the corresponding pull request. This message is automatically generated by a bot. |
Describe the bug
OpenTelemetry instrumentation is still active even when the SDK is disabled, therefore performing a non trivial amount of work and allocations that are not needed.
See the following flamegraph:
This must be corrected.
Expected behavior
When
quarkus.otel.sdk.disabled=true
the amount of OpenTelemetry related work must be near zero.Actual behavior
14,23% of all samples in the above flamegraph are OpenTelemetry related.
How to Reproduce?
Using this project: https://github.com/brunobat/quarkus-observability-perf
Set
quarkus.otel.sdk.disabled=true
Executing this hyperfoill test script to generate loa: https://github.com/brunobat/quarkus-observability-perf/blob/main/hyperfoil-scripts/quarkus-otel-perf.hf.yaml
And profiling the the execution with async profiler.
Data of the test execution can be seen performance test environment. Please contact me for details.
This affects all versions of the OpenTelemetry extension.
The text was updated successfully, but these errors were encountered: