Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenTelemetry instrumentation still active after quarkus.otel.sdk.disabled=true #43502

Closed
brunobat opened this issue Sep 25, 2024 · 5 comments · Fixed by #43535
Closed

OpenTelemetry instrumentation still active after quarkus.otel.sdk.disabled=true #43502

brunobat opened this issue Sep 25, 2024 · 5 comments · Fixed by #43535
Labels
area/tracing kind/bug Something isn't working
Milestone

Comments

@brunobat
Copy link
Contributor

brunobat commented Sep 25, 2024

Describe the bug

OpenTelemetry instrumentation is still active even when the SDK is disabled, therefore performing a non trivial amount of work and allocations that are not needed.

See the following flamegraph:
Screenshot 2024-09-25 at 17 46 14

This must be corrected.

Expected behavior

When quarkus.otel.sdk.disabled=true the amount of OpenTelemetry related work must be near zero.

Actual behavior

14,23% of all samples in the above flamegraph are OpenTelemetry related.

How to Reproduce?

Using this project: https://github.com/brunobat/quarkus-observability-perf
Set quarkus.otel.sdk.disabled=true
Executing this hyperfoill test script to generate loa: https://github.com/brunobat/quarkus-observability-perf/blob/main/hyperfoil-scripts/quarkus-otel-perf.hf.yaml
And profiling the the execution with async profiler.

Data of the test execution can be seen performance test environment. Please contact me for details.

This affects all versions of the OpenTelemetry extension.

@brunobat
Copy link
Contributor Author

quarkus.otel.sdk.disabled must be checked on each OTel related recorder.

@geoand
Copy link
Contributor

geoand commented Sep 26, 2024

Seems like something we should fix for 3.15

Copy link

quarkus-bot bot commented Sep 30, 2024

@brunobat triage/backport* labels may not be added to an issue. Please add them to the corresponding pull request.

This message is automatically generated by a bot.

@brunobat
Copy link
Contributor Author

brunobat commented Oct 3, 2024

This is the flamegraph after the merge when OTel is disabled at runtime:

Image

Th PR seems ok.

Copy link

quarkus-bot bot commented Oct 23, 2024

@brunobat triage/backport* labels may not be added to an issue. Please add them to the corresponding pull request.

This message is automatically generated by a bot.

@gsmet gsmet modified the milestones: 3.16.0.CR1, 3.15.2 Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tracing kind/bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants